Re: _NET_WM_NAME support patch

[Dmitry Timoshkov]

"Ilya Konstantinov"  wrote:
> This patch adds a _NET_WM_NAME(UTF8_STRING) property to every window,
> storing it's title in non-ambigous UTF8 encoding. This is a part of the
> NET_WM standard. The UTF8 title feature is currently implemented only
> by KWin (KDE's window manager), but is adopted by both GNOME and KDE
> camps.

@@ -746,12 +748,32 @@ BOOL X11DRV_SetWindowText( HWND hwnd, LP
             return FALSE;
         }
         WideCharToMultiByte(text_cp, 0, text, -1, buffer, count, NULL, NULL);
+        
+        count = utf8_wcstombs(text, strlenW(text), utf8_buffer, 0);

Why didn't you use win32 call instead of a purely internal one?

count = WideCharToMultiByte( CP_UTF8, 0, text, -1, NULL, 0, NULL, NULL );
utf8_buffer = HeapAlloc( GetProcessHeap(), 0, count );
count = WideCharToMultiByte( CP_UTF8, 0, text, -1, utf8_buffer, count, NULL, NULL );

--
Dmitry.