Re: d3dx9: Add adjacency generation for D3DXCreateCylinder()

[Matteo Bruni]

2015-10-26 14:33 GMT+01:00 Gediminas Jakutis :
> dlls/d3dx9_36/mesh.c | 23 +++++++++++++++++------
>  1 file changed, 17 insertions(+), 6 deletions(-)

Please resend with your Signed-off-by tag, preferably via git send-email.

Otherwise the patch looks good to me. Some kind of test for the
adjacency data would be nice to have, maybe in a followup patch...

d3dx9: Add adjacency generation for D3DXCreateCylinder()

[Gediminas Jakutis]

On 2015.10.26 19:52, Matteo Bruni wrote:
> 2015-10-26 14:33 GMT+01:00 Gediminas Jakutis :
> > dlls/d3dx9_36/mesh.c | 23 +++++++++++++++++------
> >  1 file changed, 17 insertions(+), 6 deletions(-)
>
> Please resend with your Signed-off-by tag, preferably via git send-email.

Done.
> Otherwise the patch looks good to me. Some kind of test for the
> adjacency data would be nice to have, maybe in a followup patch...

Good day!

This code is identical (save for variable names) to adjacency generation
portion of commit fe802d92bbe40d68e3ce61e1f30de1f0db531224
The way it is structured, adding tests would in essence be just an indirect
test for the GenerateAdjacency function. Which is why the aforementioned commit
it was based off does not include such tests, either.

d3dx9: Add adjacency generation for D3DXCreateCylinder()

[Matteo Bruni]

2015-10-26 19:18 GMT+01:00 Gediminas Jakutis :
> On 2015.10.26 19:52, Matteo Bruni wrote:
> > 2015-10-26 14:33 GMT+01:00 Gediminas Jakutis :
> > > dlls/d3dx9_36/mesh.c | 23 +++++++++++++++++------
> > >  1 file changed, 17 insertions(+), 6 deletions(-)
> >
> > Please resend with your Signed-off-by tag, preferably via git send-email.
>
> Done.

Thanks!
> > Otherwise the patch looks good to me. Some kind of test for the
> > adjacency data would be nice to have, maybe in a followup patch...
>
> Good day!

Hi :)
> This code is identical (save for variable names) to adjacency generation
> portion of commit fe802d92bbe40d68e3ce61e1f30de1f0db531224
> The way it is structured, adding tests would in essence be just an indirect
> test for the GenerateAdjacency function. Which is why the aforementioned commit
> it was based off does not include such tests, either.

Yes, I know, but that is an implementation detail. Native might not do
the same and in any case the tests should not care about what the
implementation does or doesn't do.

d3dx9: Add adjacency generation for D3DXCreateCylinder()

[Matteo Bruni]

2015-10-26 19:39 GMT+01:00 Matteo Bruni :
> 2015-10-26 19:18 GMT+01:00 Gediminas Jakutis :
> > This code is identical (save for variable names) to adjacency generation
> > portion of commit fe802d92bbe40d68e3ce61e1f30de1f0db531224
> > The way it is structured, adding tests would in essence be just an indirect
> > test for the GenerateAdjacency function. Which is why the aforementioned commit
> > it was based off does not include such tests, either.
>
> Yes, I know, but that is an implementation detail. Native might not do
> the same and in any case the tests should not care about what the
> implementation does or doesn't do.

Except for the observable behavior, of course...