Re: [PATCH 4/5] d3dx9_36: Implement ID3DXFileEnumObjectImpl_GetChildren & ID3DXFileEnumObjectImpl_GetChild and add stubbed interface for ID3DXFileData.

[Rico Schüller]

On 22.10.2012 21:28, Christian Costa wrote:
> +static HRESULT WINAPI ID3DXFileDataImpl_GetType(ID3DXFileData *iface, GUID* guid)

Spacing. msdn says "const GUID *pType" see 
http://msdn.microsoft.com/en-us/library/windows/desktop/bb205843%28v=vs.85%2.... 
Is it a bug in msdn?
> - ID3DXFileDataImpl* object;

*object?
> - object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(ID3DXFileDataImpl));

I'd use sizeof(*object), but that's probably only a matter of taste.

[PATCH 4/5] d3dx9_36: Implement ID3DXFileEnumObjectImpl_GetChildren & ID3DXFileEnumObjectImpl_GetChild and add stubbed interface for ID3DXFileData.

[Christian Costa]

Le 22/10/2012 22:29, Rico Schüller a écrit :
> On 22.10.2012 21:28, Christian Costa wrote:
> > +static HRESULT WINAPI ID3DXFileDataImpl_GetType(ID3DXFileData 
> > *iface, GUID* guid)
>
> Spacing. msdn says "const GUID *pType" see 
> http://msdn.microsoft.com/en-us/library/windows/desktop/bb205843%28v=vs.85%2.... 
> Is it a bug in msdn?
> > - ID3DXFileDataImpl* object;
>
> *object?
> > - object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
> >
> > sizeof(ID3DXFileDataImpl));
>
> I'd use sizeof(*object), but that's probably only a matter of taste.

I use to do it this way but I don't have particular taste. If 
sizeof(*object) is the Wine preferred way I can change it.

[PATCH 4/5] d3dx9_36: Implement ID3DXFileEnumObjectImpl_GetChildren & ID3DXFileEnumObjectImpl_GetChild and add stubbed interface for ID3DXFileData.

[Dmitry Timoshkov]

Christian Costa  wrote:
> > > - object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
> > >
> > > sizeof(ID3DXFileDataImpl));
> >
> > I'd use sizeof(*object), but that's probably only a matter of taste.
>
> I use to do it this way but I don't have particular taste. If 
> sizeof(*object) is the Wine preferred way I can change it.

If type of the 'object' will change in future that won't require any
changes and there will be no possible problems if the expression in
sizeof() doesn't change. So that's not 'a Wine preferred way' but
something that makes life easier in general.

[PATCH 4/5] d3dx9_36: Implement ID3DXFileEnumObjectImpl_GetChildren & ID3DXFileEnumObjectImpl_GetChild and add stubbed interface for ID3DXFileData.

[Christian Costa]

Le 22/10/2012 22:29, Rico Schüller a écrit :
> On 22.10.2012 21:28, Christian Costa wrote:
> > +static HRESULT WINAPI ID3DXFileDataImpl_GetType(ID3DXFileData 
> > *iface, GUID* guid)
>
> Spacing. msdn says "const GUID *pType" see 
> http://msdn.microsoft.com/en-us/library/windows/desktop/bb205843%28v=vs.85%2.... 
> Is it a bug in msdn?

I think so because it's GUID* in the header.