[PATCH] ntdll: Don't abort if we overflow the thread debug buffer.

[Zebediah Figura]

Instead, just print it as-is.

Signed-off-by: Zebediah Figura 
---
I encountered this abort() while trying to play a certain video with
winegstreamer, which spewed far too much debug data upon failing to find an
adequate decoder.

dlls/ntdll/debugtools.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/ntdll/debugtools.c b/dlls/ntdll/debugtools.c
index 2c8287d..b418c74 100644
--- a/dlls/ntdll/debugtools.c
+++ b/dlls/ntdll/debugtools.c
@@ -132,10 +132,10 @@ static int NTDLL_dbg_vprintf( const char *format, va_list args )
      * debug output */
     if ((ret == -1) || (ret >= sizeof(info->output) - (info->out_pos - info->output)))
     {
-       fprintf( stderr, "wine_dbg_vprintf: debugstr buffer overflow (contents: '%s')\n",
-                info->output);
-       info->out_pos = info->output;
-       abort();
+        write( 2, info->output, info->out_pos - info->output );
+        vfprintf( stderr, format, args );
+        info->out_pos = info->output;
+        return ret;
     }

for (end = ret; end > 0; end--) if (info->out_pos[end - 1] == '\n') break;

[Alexandre Julliard]

Zebediah Figura  writes:
> Instead, just print it as-is.
> Signed-off-by: Zebediah Figura
>
> I encountered this abort() while trying to play a certain video with
> winegstreamer, which spewed far too much debug data upon failing to find an
> adequate decoder.

The abort is a feature, please fix the corresponding traces
instead. Usually it's because of a missing \n or debugstr_a().

[Zebediah Figura]

On 05/07/18 13:47, Alexandre Julliard wrote:
> Zebediah Figura  writes:
> > Instead, just print it as-is.
> > Signed-off-by: Zebediah Figura
> >
> > I encountered this abort() while trying to play a certain video with
> > winegstreamer, which spewed far too much debug data upon failing to find an
> > adequate decoder.
>
> The abort is a feature, please fix the corresponding traces
> instead. Usually it's because of a missing \n or debugstr_a().

Fair enough, although I guess this doesn't give us an easy way to print
data longer than 300 characters.

[Alexandre Julliard]

Zebediah Figura  writes:
> On 05/07/18 13:47, Alexandre Julliard wrote:
> > Zebediah Figura  writes:
> > > Instead, just print it as-is.
> > > Signed-off-by: Zebediah Figura
> > >
> > > I encountered this abort() while trying to play a certain video with
> > > winegstreamer, which spewed far too much debug data upon failing to find an
> > > adequate decoder.
> >
> > The abort is a feature, please fix the corresponding traces
> > instead. Usually it's because of a missing \n or debugstr_a().
>
> Fair enough, although I guess this doesn't give us an easy way to print
> data longer than 300 characters.

That's to encourage keeping individual traces to a manageable size, so
that they can be line-buffered. Arbitrarily long traces would most
likely become unreadable anyway when they get mixed up with output from
other threads.