This is related to my last post. The buttons wine draw actually have wrong borders, like for example a normal window has this close button:
::::::::::::::::::::::::::::::00 :: 3300 :: 3300 :: #### #### 3300 :: #### #### 3300 :: ######## 3300 :: #### 3300 :: ######## 3300 :: #### #### 3300 :: #### #### 3300 :: 3300 :: 3300 ::333333333333333333333333333300 00000000000000000000000000000000
where: '::' is color ffffff '33' is color 808080 '00' is color 000000 (404040 in win2k & winxp, not sure about winme) ' ' is the background (default is c0c0c0, but d4d0c8 in win2k...) '##' is black
but wine draws it as:
================================00 ==::::::::::::::::::::::::::::3300 ==:: 3300 ==:: #### #### 3300 ==:: #### #### 3300 ==:: #### #### 3300 ==:: ######## 3300 ==:: #### 3300 ==:: ######## 3300 ==:: #### #### 3300 ==:: #### #### 3300 ==:: #### #### 3300 ==:: 3300 ==33333333333333333333333333333300 0000000000000000000000000000000000
where '==' is some other color between '::' and ' '
There are two mistakes: 1. The borders aren't correct. For an active unpushed button, there should only be one "top-left edge". For a pushed button, there should be only one "bottom-right edge" (and inner/outer "top-left edge"s) 2. The 'X' should be drawn a bit more to the right and higher, and smaller. Smaller, because with the correct edges, we need to have (for an unpushed button) a spacing of 3, 2, 2, 2 pixels for the left, top, right, bottom sides respectively, between the 'X' and the edges (look at the correct example above). Higher and more to the right, because after making the 'X' smaller, it should have the correct spacing.
Comments please... :)
_______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com
Hi,
On Tue, Oct 12, 2004 at 09:56:30AM -0700, William Poetra Yoga Hadisoesen wrote:
This is related to my last post. The buttons wine draw actually have wrong borders, like for example a normal window has this close button:
That could be rather deliberate, since I'd say we're not really out to do a blatant "boring" copy of Microsoft's work... (while it's obvious that we are often forced to follow in Microsoft's footsteps in this project in order to get Windows programs to run at all, it's not as if we ALWAYS want to do that exactly - and sometimes there are even better ways to implement something...)
If it really makes a functional difference, then I guess it should be fixed, otherwise why not leave it as is?
Andreas Mohr
--- Andreas Mohr andi@rhlx01.fht-esslingen.de wrote:
Hi,
On Tue, Oct 12, 2004 at 09:56:30AM -0700, William Poetra Yoga Hadisoesen wrote:
This is related to my last post. The buttons wine draw actually have wrong borders, like for example a normal window has this close button:
That could be rather deliberate, since I'd say we're not really out to do a blatant "boring" copy of Microsoft's work... (while it's obvious that we are often forced to follow in Microsoft's footsteps in this project in order to get Windows programs to run at all, it's not as if we ALWAYS want to do that exactly - and sometimes there are even better ways to implement something...)
If it really makes a functional difference, then I guess it should be fixed, otherwise why not leave it as is?
Andreas Mohr
Well, WINE is supposed to provide a Win32-compatible API, IMO. At least it looks right if we fix it. This does have some positive impacts on the development of WINE, such as: 1. Developers coming from Windows can have the same "look and feel". This increases their productivity, although indirectly. When people see something different but similar to the one they see everyday, their attention will be divided to the new object and the work they are doing. And their motivation to work will decrease, too, if the GUI doesn't get fixed. 2. Windows users looking at WINE will reject it straight away, because it doesn't look like a "professionaly-made" software, and maybe mocking it as a carelessly written software, with sloppy GUI. Remember, some users become developers.
__________________________________ Do you Yahoo!? Yahoo! Mail Address AutoComplete - You start. We finish. http://promotions.yahoo.com/new_mail
William Poetra Yoga Hadisoesen wrote:
There are two mistakes:
- The borders aren't correct. For an active unpushed button, there should only
be one "top-left edge". For a pushed button, there should be only one "bottom-right edge" (and inner/outer "top-left edge"s)
Actually there should really be two top-left edges, but one just happens to be the same color as the interior.
- Filip
--- Filip Navara xnavara@volny.cz wrote:
William Poetra Yoga Hadisoesen wrote:
There are two mistakes:
- The borders aren't correct. For an active unpushed button, there should
only
be one "top-left edge". For a pushed button, there should be only one "bottom-right edge" (and inner/outer "top-left edge"s)
Actually there should really be two top-left edges, but one just happens to be the same color as the interior.
- Filip
Yeah, thanks. I changed the color settings in dlls/user/uitools.c. Please look at the other thread ;)
__________________________________ Do you Yahoo!? Yahoo! Mail Address AutoComplete - You start. We finish. http://promotions.yahoo.com/new_mail
-
Andreas Mohr -
Filip Navara -
William Poetra Yoga Hadisoesen