13 Nov
2015
13 Nov
'15
12:55 p.m.
The patch isn't wrong, but I don't think the subject is an appropriate description of what it does.
14 Nov
14 Nov
4:52 a.m.
New subject: [PATCH] wined3d: Turn magic values into static constants.
2015-11-13 5:55 GMT-07:00 Henri Verbeet hverbeet@gmail.com:
The patch isn't wrong, but I don't think the subject is an appropriate description of what it does.
What would you like the subject to say?
-Alex
6:44 a.m.
New subject: [PATCH] wined3d: Turn magic values into static constants.
2015-11-14 12:52 GMT+08:00 Alex Henrie alexhenrie24@gmail.com:
What would you like the subject to say?
How about "Turn constants values into static constants.", as the magic values are still magic values?
--
Have a nice day!
Zhenbo Li
3473
Age (days ago)
3474
Last active (days ago)
2 comments
3 participants
participants (3)
-
Alex Henrie -
Henri Verbeet -
Zhenbo Li