Re: LOCALE: Don't copy value if buffer is too small

[Alexandre Julliard]

Fabian Cenedese  writes:
> Ok, I saw that you fixed the WCHAR/byte mess. But there is still a possibility that
> the function can copy a string longer than buffer if it already has an appended null.

That shouldn't happen, NtQueryValue should have signaled an overflow
in that case. Do you have a test case showing the problem?

LOCALE: Don't copy value if buffer is too small

[Fabian Cenedese]

> > Ok, I saw that you fixed the WCHAR/byte mess. But there is still a possibility that
> > the function can copy a string longer than buffer if it already has an appended null.
>
> That shouldn't happen, NtQueryValue should have signaled an overflow
> in that case. Do you have a test case showing the problem?

Hmm.. not anymore. My program that failed works fine now. I started this
patch when I assumed that the length argument is in bytes. But as you
now changed all calls to WCHAR it doesn't even get to the copying
anymore. So I'm sorry, forget that patch.

Thanks

bye   Fabi