At 08:04 PM 01/05/2001 +0200, you wrote:
as of today, the added files are marked with the &&& mark (instead of the +++ and --- for the diffs), which of course causes some issues when you use the whole file as a patch (normally, all the added files are at the end; so the "easy" way of doing it is to remove that part, apply the patch, and then create the new files)
<snip>
I'd say it's a documented feature ;-),
Documented ? Oops, I missed completely this part. This weekend I have browsed the wonderful Wine user manual for the first time , since I have now a computer with a working db2html - now I know what *is* the Wine user manual ;-) I have not seen where this info is hiding.
Maybe it was in one of your (defunct) WWN. I tried to read them but I probably was lazy too.
Btw, your successor has problems to get in the game; I noticed on LinuxToday that the last Kernel Cousin Wine was showing a 'slow week' - the week where Marcus posted CUPS support - IMHO the more interesting patch since months for all non-games apps. He is not following wine-patches and wine-cvs it seems :-/
I'll try to give it a look later on
I see no reason for you to work on this rather trivial matter. All that is needed is to know the problem. I should have guessed it but I was probably too stressed by the idea of having this 200k patch to look at ;-( Now it's done, thanks for the tip.
Gerard
On Tue, 1 May 2001, gerard patel wrote: [...]
This weekend I have browsed the wonderful Wine user manual for the first time , since I have now a computer with a working db2html - now I know what *is* the Wine user manual ;-)
This is the first time you saw the 'Wine user manual'??? You probably meant something else, it's right there on the WineHQ site: - there's a big 'Help!' heading with 'WINE Documentation and Support, FAQ and HOWTO.' as the subtitle. Click on it. - there, the first item is 'Official Wine documentation', click on it - and then you have the choice of: - the 'Wine User Guide' http://www.winehq.com/Docs/wine-user/ - the 'Winelib User Guide' http://www.winehq.com/Docs/winelib-user/ - the 'Wine Developers Guide' http://www.winehq.com/Docs/wine-devel/ - the 'Wine Packagers Guide' http://www.winehq.com/Docs/wine-pkg/
It should even be up to date but I'm not entirely sure. If not then something must be done about it.
I have not seen where this info is hiding.
That can be harder to track, I agree :-)
-- Francois Gouget fgouget@free.fr http://fgouget.free.fr/ 145 = 1! + 4! + 5!
While looking at
- the 'Wine Developers Guide' http://www.winehq.com/Docs/wine-devel/
on page: http://www.winehq.com/Docs/wine-devel/dbg-notes.shtml I notice the following.
try to avoid the style: FIXME(xxx, "(fd=%d, file=%s): stub\n", fd, name);
but use: FIXME(xxx, "(fd=%d, file=%s): stub\n", fd, name);
The reason is that if you want to grep for things, you would search for FIXME but in the first case there is no additional information available, where in the second one, there is (e.g. the word stub)
But both line are the same, I'm guessing the first was ment to look like:
FIXME(xxx, "(fd=%d, file=%s)\n", fd, name);
Regards Simeon.
On Wed, 2 May 2001, Simeon Pilgrim wrote: [...]
try to avoid the style: FIXME(xxx, "(fd=%d, file=%s): stub\n", fd, name);
but use: FIXME(xxx, "(fd=%d, file=%s): stub\n", fd, name);
The reason is that if you want to grep for things, you would search for FIXME but in the first case there is no additional information available, where in the second one, there is (e.g. the word stub)
But both line are the same, I'm guessing the first was ment to look like:
FIXME(xxx, "(fd=%d, file=%s)\n", fd, name);
I think you're right. I sent a patch to wine-patches. See, fixing the documentation is simple :-)
Changelog:
Simeon Pilgrim simeon.pilgrim@alliedtelesyn.co.nz
* documentation/debugging.sgml Typo in stub-reporting style description
-- Francois Gouget fgouget@free.fr http://fgouget.free.fr/ Broadcast message : fin du monde dans cinq minutes, repentez vous !
Documented ? Oops, I missed completely this part. This weekend I have browsed the wonderful Wine user manual for the first time , since I have now a computer with a working db2html - now I know what *is* the Wine user manual ;-) I have not seen where this info is hiding.
well, it has been only published on the winehq administrators list... sorry about that.
Btw, your successor has problems to get in the game; I noticed on LinuxToday that the last Kernel Cousin Wine was showing a 'slow week' - the week where Marcus posted CUPS support - IMHO the more interesting patch since months for all non-games apps. He is not following wine-patches and wine-cvs it seems :-/
well, as things go, Brian is only browsing the wine-devel list from winehq, but list of patches hasn't been moved back in. a matter of a few issues I think
A+
-
eric pouech -
Francois Gouget -
gerard patel -
Simeon Pilgrim