Re: wine/dlls/comctl32 syslink.c

[Thomas Weidenmueller]

@@ -1666,9 +1712,8 @@
  */
 VOID SYSLINK_Register (void)
 {
-    WNDCLASSW wndClass;
+    WNDCLASSW wndClass = {0};

-    ZeroMemory (&wndClass, sizeof(wndClass));
     wndClass.style         = CS_GLOBALCLASS | CS_VREDRAW | CS_HREDRAW;
     wndClass.lpfnWndProc   = SysLinkWindowProc;
     wndClass.cbClsExtra    = 0;

Is there a reason this change wasn't applied? Calling ZeroMemory is
slower and prevents certain optimizations by the compiler.

- Thomas

wine/dlls/comctl32 syslink.c

[Alexandre Julliard]

Thomas Weidenmueller  writes:
> Is there a reason this change wasn't applied? Calling ZeroMemory is
> slower and prevents certain optimizations by the compiler.

Initializing auto structures that way is much less portable. And
control registration is not exactly a critical code path...