Re: [3/4] winhttp/tests: Send a not empty payload in the server authorization response, check the received data on the client side.

[Hans Leidekker]

On Mon, 2015-12-07 at 13:16 +0800, Dmitry Timoshkov wrote:
> Signed-off-by: Dmitry Timoshkov
>
> dlls/winhttp/tests/winhttp.c | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)

It fails here:
winhttp.c:2389: Test failed: expected 11, got 15

[3/4] winhttp/tests: Send a not empty payload in the server authorization response, check the received data on the client side.

[Dmitry Timoshkov]

Hans Leidekker  wrote:
> On Mon, 2015-12-07 at 13:16 +0800, Dmitry Timoshkov wrote:
> > Signed-off-by: Dmitry Timoshkov
> >
> > dlls/winhttp/tests/winhttp.c | 33 +++++++++++++++++++++++++++++++++
> >  1 file changed, 33 insertions(+)
>
> It fails here:
> winhttp.c:2389: Test failed: expected 11, got 15

is that a clean build + fresh .wine prefix? Just applied first 3 patches from
the series on top of clean Wine source, recompiled, created new ~/.wine and
the tests pass cleanly for me.

[3/4] winhttp/tests: Send a not empty payload in the server authorization response, check the received data on the client side.

[Hans Leidekker]

On Mon, 2015-12-07 at 18:16 +0800, Dmitry Timoshkov wrote:
> Hans Leidekker  wrote:
> > On Mon, 2015-12-07 at 13:16 +0800, Dmitry Timoshkov wrote:
> > > Signed-off-by: Dmitry Timoshkov
> > >
> > > dlls/winhttp/tests/winhttp.c | 33 +++++++++++++++++++++++++++++++++
> > >  1 file changed, 33 insertions(+)
> >
> > It fails here:
> > winhttp.c:2389: Test failed: expected 11, got 15
>
> is that a clean build + fresh .wine prefix? Just applied first 3 patches from
> the series on top of clean Wine source, recompiled, created new ~/.wine and
> the tests pass cleanly for me.

It is a clean build. If I run the test with WINEDEBUG=+winhttp it passes.

[3/4] winhttp/tests: Send a not empty payload in the server authorization response, check the received data on the client side.

[Hans Leidekker]

On Mon, 2015-12-07 at 11:27 +0100, Hans Leidekker wrote:
> > > It fails here:
> > > winhttp.c:2389: Test failed: expected 11, got 15
> >
> > is that a clean build + fresh .wine prefix? Just applied first 3 patches from
> > the series on top of clean Wine source, recompiled, created new ~/.wine and
> > the tests pass cleanly for me.
>
> It is a clean build. If I run the test with WINEDEBUG=+winhttp it passes.

You have trailing data in your test. You set Content-Length to 12 but send 
sizeof("Unauthorized\r\n\r\n") - 1 bytes. If I remove the line endings it
passes reliably.

[3/4] winhttp/tests: Send a not empty payload in the server authorization response, check the received data on the client side.

[Nikolay Sivov]

On 07.12.2015 12:44, Hans Leidekker wrote:
> On Mon, 2015-12-07 at 13:16 +0800, Dmitry Timoshkov wrote:
> > Signed-off-by: Dmitry Timoshkov
> >
> > dlls/winhttp/tests/winhttp.c | 33 +++++++++++++++++++++++++++++++++
> >   1 file changed, 33 insertions(+)
>
> It fails here:
> winhttp.c:2389: Test failed: expected 11, got 15

Can confirm, fails in the same way here.