Just curious if Alexandre missed my patches for regedit and my trace fix for uninstaller, or if there is a backlog of commits to be done, or if he even plans to commit them, and if not, why..
http://www.winehq.org/pipermail/wine-patches/2007-April/038566.html - Spelling fixes for regedit
http://www.winehq.org/pipermail/wine-patches/2007-April/038568.html - Correct parsing of /? and unknown parameters on command line for regedit
http://www.winehq.org/pipermail/wine-patches/2007-April/038569.html - Fix for a trace in uninstaller (Make sure it shows the current selection, not the old one)
I am aware that my attempt 6 to scan hkcu was not attached to the original email for it, so I resent that, but expect a day or 2 delay for it to be committed, but the others, I figured would have been by now.
"Tom Spear" speeddymon@gmail.com writes:
Just curious if Alexandre missed my patches for regedit and my trace fix for uninstaller, or if there is a backlog of commits to be done, or if he even plans to commit them, and if not, why..
You have been sending way too many patches lately, most of which are broken one way or another, so I just stopped looking at them. You need to spend more time on each patch to make sure it's correct, properly formatted, that the patch is included in the mail, etc.
That's particularly true for cosmetic patches like typo fixes; if I have to spend more than 10 seconds on such a patch, chances are it will end up in /dev/null.
On 4/26/07, Alexandre Julliard julliard@winehq.org wrote:
That's particularly true for cosmetic patches like typo fixes; if I have to spend more than 10 seconds on such a patch, chances are it will end up in /dev/null.
Ok, so then if I resend them now, will you take a look? I believe I have fixed every problem with each one, as I havent gotten any more comments about something being borked.
"Tom Spear" speeddymon@gmail.com writes:
Ok, so then if I resend them now, will you take a look? I believe I have fixed every problem with each one, as I havent gotten any more comments about something being borked.
No, resend just one, making absolutely sure that you got everything right, and wait for it to be committed before sending the next one. You have to make sure you can walk before you try to run.
On 4/26/07, Alexandre Julliard julliard@winehq.org wrote:
"Tom Spear" speeddymon@gmail.com writes:
Ok, so then if I resend them now, will you take a look? I believe I have fixed every problem with each one, as I havent gotten any more comments about something being borked.
No, resend just one, making absolutely sure that you got everything right, and wait for it to be committed before sending the next one. You have to make sure you can walk before you try to run.
Ok. Any particular order? I'll do a regedit one for now..
-
Alexandre Julliard -
Tom Spear