Waste of time, there are several objects that should be LTR (like the news list) and some images that need to be flipped horizontally, plus I have already done all the stuff I said, basically this patch is useless...
On 17/10/10 13:52, Yaron Shahrabani wrote:
Waste of time, there are several objects that should be LTR (like the news list) and some images that need to be flipped horizontally, plus I have already done all the stuff I said, basically this patch is useless...
I will accept and admit your accusation of me not being psychic in sensing your incoming patches. Your patches are, indeed, more comprehensive than mine, but I believe they are inferior in at least one important aspect.
You direct the code to load styles-rtl.css instead of styles.css. This encourages future site maintainers to perform changes to the CSS that will break the RTL version of it, due to not noticing the existence of the rtl version. I believe the approach I took, of including styles.css, and then including a second css only aimed at correcting the what needs to be corrected, would work better in the long run.
Another manifestation of this difference can be seen when you place a "dir=" directive on the <body> tag of "content_print.template". This is change does not pass strict HTML validation, and would be unnecessary had the two CSS approaches been used.
Shachar
On Sun, Oct 17, 2010 at 2:18 PM, Shachar Shemesh shachar@shemesh.bizwrote:
On 17/10/10 13:52, Yaron Shahrabani wrote:
Waste of time, there are several objects that should be LTR (like the news list) and some images that need to be flipped horizontally, plus I have already done all the stuff I said, basically this patch is useless...
I will accept and admit your accusation of me not being psychic in sensing your incoming patches. Your patches are, indeed, more comprehensive than mine, but I believe they are inferior in at least one important aspect.
For some reason I got your patch only half an hour ago so I was absolutely sure you sent it way later...
You direct the code to load styles-rtl.css instead of styles.css. This encourages future site maintainers to perform changes to the CSS that will break the RTL version of it, due to not noticing the existence of the rtl version. I believe the approach I took, of including styles.css, and then including a second css only aimed at correcting the what needs to be corrected, would work better in the long run.
It is actually a linked CSS file... I used @import ("styles.css") in order to maintain the original CSS, its the same approach you took only from a different point of view and practically there's no difference... (I can switch the method in a matter of click :) ).
Another manifestation of this difference can be seen when you place a "dir=" directive on the <body> tag of "content_print.template". This is change does not pass strict HTML validation, and would be unnecessary had the two CSS approaches been used.
So they should be combined?
Shachar
-- Shachar Shemesh Lingnu Open Source Consulting Ltd. http://www.lingnu.com
On 17/10/10 15:00, Yaron Shahrabani wrote:
Another manifestation of this difference can be seen when you place a "dir=" directive on the <body> tag of "content_print.template". This is change does not pass strict HTML validation, and would be unnecessary had the two CSS approaches been used.So they should be combined?
I think, no. I think the RTL file should only contain RTL related stuff, and will therefor be okay to use it also in the content_print file, without adding a tag to the body.
Just MHO.
Shachar
On Sun, Oct 17, 2010 at 3:07 PM, Shachar Shemesh shachar@shemesh.bizwrote:
On 17/10/10 15:00, Yaron Shahrabani wrote:
Another manifestation of this difference can be seen when you place a "dir=" directive on the <body> tag of "content_print.template". This is change does not pass strict HTML validation, and would be unnecessary had the two CSS approaches been used.
So they should be combined?
I think, no. I think the RTL file should only contain RTL related stuff,
and will therefor be okay to use it also in the content_print file, without adding a tag to the body.
Currently the RTL file I created contains only RTL stuff (and imports the other). It could be loaded in addition to the winehq_styles.css (where is this file anyway?) in content_print.template, this will solve the entire problem and ensures the site would look at its best.
Kind regards, Yaron Shahrabani.
Just MHO.
Shachar
-- Shachar Shemesh Lingnu Open Source Consulting Ltd.http://www.lingnu.com
-
Shachar Shemesh -
Yaron Shahrabani