Re: [PATCH 1/5] widl: Handle aggregate returns in a MSVC compatible way.

[Piotr Caban]

On 09/05/14 15:50, Henri Verbeet wrote:
> -static D2D1_COLOR_F STDMETHODCALLTYPE d2d_solid_color_brush_GetColor(ID2D1SolidColorBrush *iface)
> +static void STDMETHODCALLTYPE d2d_solid_color_brush_GetColor(ID2D1SolidColorBrush *iface, D2D1_COLOR_F *color)
>   {
>       static const D2D1_COLOR_F black = {0.0f, 0.0f, 0.0f, 1.0f};
>   FIXME("iface %p stub!\n", iface);
>
> - return black;
> - *color = black;
> }

Shouldn't it return pointer to D2D1_COLOR_F?

[PATCH 1/5] widl: Handle aggregate returns in a MSVC compatible way.

[Henri Verbeet]

On 5 September 2014 16:03, Piotr Caban  wrote:
> On 09/05/14 15:50, Henri Verbeet wrote:
> > -static D2D1_COLOR_F STDMETHODCALLTYPE
> > d2d_solid_color_brush_GetColor(ID2D1SolidColorBrush *iface)
> > +static void STDMETHODCALLTYPE
> > d2d_solid_color_brush_GetColor(ID2D1SolidColorBrush *iface, D2D1_COLOR_F
> > *color)
> >   {
> >       static const D2D1_COLOR_F black = {0.0f, 0.0f, 0.0f, 1.0f};
> >   FIXME("iface %p stub!\n", iface);
> >
> > - return black;
> > - *color = black;
> > }
>
> Shouldn't it return pointer to D2D1_COLOR_F?

Not as far as I'm aware.

[PATCH 1/5] widl: Handle aggregate returns in a MSVC compatible way.

[Alexandre Julliard]

Henri Verbeet  writes:
> On 5 September 2014 16:03, Piotr Caban  wrote:
> > On 09/05/14 15:50, Henri Verbeet wrote:
> > > -static D2D1_COLOR_F STDMETHODCALLTYPE
> > > d2d_solid_color_brush_GetColor(ID2D1SolidColorBrush *iface)
> > > +static void STDMETHODCALLTYPE
> > > d2d_solid_color_brush_GetColor(ID2D1SolidColorBrush *iface, D2D1_COLOR_F
> > > *color)
> > >   {
> > >       static const D2D1_COLOR_F black = {0.0f, 0.0f, 0.0f, 1.0f};
> > >   FIXME("iface %p stub!\n", iface);
> > >
> > > - return black;
> > > - *color = black;
> > > }
> >
> > Shouldn't it return pointer to D2D1_COLOR_F?
>
> Not as far as I'm aware.

Yes, it should.