Re: [1/1] winejoystick.drv/joystick_osx.c: fixed axes mapping, add feature support

[Hugh McMaster]

On Friday, 10 June 2016 4:11 PM, David Lawrie wrote:
> This patch fixes Slider and Ry/Rx axes mapping and adds support for
> general multi-axis controllers (up to 6-axis controllers), steering
> wheels w/ accelerators/brakes, multiple sliders/dials/wheels (up to 3),
> rudder pedals, and throttles.
>
> Tested on OS X 10.10.5
> Signed-off-by: David Lawrie [e-mail]
>
> dlls/winejoystick.drv/joystick_osx.c | 171 ++++++++++++++++++++++++-----------
>  1 file changed, 119 insertions(+), 52 deletions(-)

Hi David,

Your patch contains a mixture of tab and space indentation.
The tabs, in particular, make the lines long and difficult to read.

Please resubmit your patch using four spaces for each level of indentation.

--
Hugh McMaster

[0/1] winejoystick.drv/joystick_osx.c: fixed axes mapping, add feature support

[DavidL]

Hi Hugh,

Version 2 of the patch fixed that and I am preparing a version 3 which will
split that patch up into smaller pieces. I see from the patch list my
version 1 patch with the poor formatting got reposted, I have no idea how
that happened as I haven't sent another e-mail. I apologize, not sure what
I did.

Cheers,
David

On Sunday, June 12, 2016, Hugh McMaster  wrote:
> On Friday, 10 June 2016 4:11 PM, David Lawrie wrote:
> > This patch fixes Slider and Ry/Rx axes mapping and adds support for
> > general multi-axis controllers (up to 6-axis controllers), steering
> > wheels w/ accelerators/brakes, multiple sliders/dials/wheels (up to 3),
> > rudder pedals, and throttles.
> >
> > Tested on OS X 10.10.5
> > Signed-off-by: David Lawrie [e-mail] javascript:;
> >
> > dlls/winejoystick.drv/joystick_osx.c | 171
>
> ++++++++++++++++++++++++-----------
> > 1 file changed, 119 insertions(+), 52 deletions(-)
>
> Hi David,
>
> Your patch contains a mixture of tab and space indentation.
> The tabs, in particular, make the lines long and difficult to read.
>
> Please resubmit your patch using four spaces for each level of indentation.
>
> --
> Hugh McMaster

[0/1] winejoystick.drv/joystick_osx.c: fixed axes mapping, add feature support

[DavidL]

To all,

Please ignore Patches with IDs 123165 & 123167 - they are accidental
resubmissions of an earlier version of a patch. I think what happened was
that I originally submitted my patches before I subscribed to the
wine-patch list serve. Re-reading the directions that I needed to be
subscribe in order to submit so that the messages would not be junked as
spam, I resubmitted my version 1 patches after subscribing. The earlier
submission must have just come through. I apologize for the inconvenience.

Cheers,
David

On Sun, Jun 12, 2016 at 11:36 AM, DavidL  wrote:
> Hi Hugh,
>
> Version 2 of the patch fixed that and I am preparing a version 3 which
> will split that patch up into smaller pieces. I see from the patch list my
> version 1 patch with the poor formatting got reposted, I have no idea how
> that happened as I haven't sent another e-mail. I apologize, not sure what
> I did.
>
> Cheers,
> David
>
> On Sunday, June 12, 2016, Hugh McMaster  wrote:
> > On Friday, 10 June 2016 4:11 PM, David Lawrie wrote:
> > > This patch fixes Slider and Ry/Rx axes mapping and adds support for
> > > general multi-axis controllers (up to 6-axis controllers), steering
> > > wheels w/ accelerators/brakes, multiple sliders/dials/wheels (up to 3),
> > > rudder pedals, and throttles.
> > >
> > > Tested on OS X 10.10.5
> > > Signed-off-by: David Lawrie [e-mail]
> > >
> > > dlls/winejoystick.drv/joystick_osx.c | 171
> >
> > ++++++++++++++++++++++++-----------
> > > 1 file changed, 119 insertions(+), 52 deletions(-)
> >
> > Hi David,
> >
> > Your patch contains a mixture of tab and space indentation.
> > The tabs, in particular, make the lines long and difficult to read.
> >
> > Please resubmit your patch using four spaces for each level of
> > indentation.
> >
> > --
> > Hugh McMaster