For some reason, a previous test sets the current directory to C:\windows\system32\ on my Windows 10 machine, which prompts message boxes as the path is not writable.
Signed-off-by: Zebediah Figura z.figura12@gmail.com --- dlls/comdlg32/tests/filedlg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dlls/comdlg32/tests/filedlg.c b/dlls/comdlg32/tests/filedlg.c index bf4d1f22eb0..165b5cd8bdc 100644 --- a/dlls/comdlg32/tests/filedlg.c +++ b/dlls/comdlg32/tests/filedlg.c @@ -1051,7 +1051,7 @@ static void test_extension(void) { OPENFILENAMEA ofn = { OPENFILENAME_SIZE_VERSION_400A }; char filename[1024] = {0}; - char curdir[MAX_PATH]; + char dir[MAX_PATH]; unsigned int i; BOOL boolret;
@@ -1070,14 +1070,14 @@ static void test_extension(void) NULL /* is a test, not an endmark! */ };
- boolret = GetCurrentDirectoryA(sizeof(curdir), curdir); + boolret = GetTempPathA(sizeof(dir), dir); ok(boolret, "Failed to get current dir err %d\n", GetLastError());
ofn.hwndOwner = NULL; ofn.lpstrFile = filename; ofn.nMaxFile = MAX_PATH; ofn.Flags = OFN_EXPLORER | OFN_ENABLEHOOK; - ofn.lpstrInitialDir = curdir; + ofn.lpstrInitialDir = dir; ofn.lpfnHook = test_extension_wndproc; ofn.nFileExtension = 0;
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=63239
Your paranoid android.
=== wvistau64 (32 bit report) ===
comdlg32: filedlg.c:1040: Test failed: TestFilter (*.abc;): expected TRUE filedlg.c:1046: Test failed: TestFilter (*.abc;): Filename is deadbeef, expected deadbeef.abc
Report errors: comdlg32:filedlg crashed (c0000005)
=== w1064v1809_he (32 bit report) ===
comdlg32: filedlg.c:1183: Test failed: GetOpenFileNameA returned 0