Re: ws2_32: return an error in SO_CONNECT_TIME stub

[Dmitry Timoshkov]

Austin English  wrote:
> @@ -2554,7 +2554,7 @@ INT WINAPI WS_getsockopt(SOCKET s, INT level,
>              }
>              *(DWORD*)optval = pretendtime++;
>              *optlen = sizeof(DWORD);
> -
>        return ret;
> -
>        return SOCKET_ERROR;
>    }

Filling out optval and optlen but returning SOCKET_ERROR doesn't make
sense. Probably Eye-Fi doesn't change the return value. What kind of
socket both of the applications do pass?

ws2_32: return an error in SO_CONNECT_TIME stub

[Austin English]

On Sun, Mar 27, 2011 at 21:41, Dmitry Timoshkov  wrote:
> Austin English  wrote:
> > @@ -2554,7 +2554,7 @@ INT WINAPI WS_getsockopt(SOCKET s, INT level,
> >              }
> >              *(DWORD*)optval = pretendtime++;
> >              *optlen = sizeof(DWORD);
> > - return ret;
> > - return SOCKET_ERROR;
> >
> > }
>
> Filling out optval and optlen but returning SOCKET_ERROR doesn't make
> sense. Probably Eye-Fi doesn't change the return value. What kind of
> socket both of the applications do pass?

For MFSX:
trace:winsock:WS_getsockopt socket: 0220, level 0xffff, name 0x700c,
ptr 0x32eac0, len 4
fixme:winsock:WS_getsockopt WS_SO_CONNECT_TIME - faking results
trace:winsock:WS_getsockopt socket: 0224, level 0xffff, name 0x700c,
ptr 0x32eac0, len 4
trace:winsock:WS_getsockopt socket: 0228, level 0xffff, name 0x700c,
ptr 0x32eac0, len 4
trace:winsock:WS_getsockopt socket: 022c, level 0xffff, name 0x700c,
ptr 0x32eac0, len 4
trace:winsock:WS_getsockopt socket: 0230, level 0xffff, name 0x700c,
ptr 0x32eac0, len 4

(full log attached, 280K uncompressed).

I don't have access to Eye-Fi, Marcus?