Re: [PATCH] winegcc: Free the temporary string arrays (Coverity)

[Alexandre Julliard]

Marcus Meissner  writes:
> Hi,
>
> This fixes CID 883, 882, 881, 880, 879, 878, 877,
> which are all basically missing strarray_free(arr)s.

winegcc is a short-lived program, there's no reason to care about memory
leaks.

[PATCH] winegcc: Free the temporary string arrays (Coverity)

[Michael Stefaniuc]

Alexandre Julliard wrote:
> Marcus Meissner  writes:
> > This fixes CID 883, 882, 881, 880, 879, 878, 877,
> > which are all basically missing strarray_free(arr)s.
>
> winegcc is a short-lived program, there's no reason to care about memory
> leaks.

Right but the problem is that people will keep running into that. This
is not the first attempt to fix those; maybe the 4th or even 5th one.
So while it isn't necessary code wise it will cut on developer time
having to deal again and again with the same "false positives".

If the code doesn't get too ugly I would vote to get the patch in.

bye
    michael

[PATCH] winegcc: Free the temporary string arrays (Coverity)

[Alexandre Julliard]

Michael Stefaniuc  writes:
> Alexandre Julliard wrote:
> > Marcus Meissner  writes:
> > > This fixes CID 883, 882, 881, 880, 879, 878, 877,
> > > which are all basically missing strarray_free(arr)s.
> >
> > winegcc is a short-lived program, there's no reason to care about memory
> > leaks.
>
> Right but the problem is that people will keep running into that. This
> is not the first attempt to fix those; maybe the 4th or even 5th one.
> So while it isn't necessary code wise it will cut on developer time
> having to deal again and again with the same "false positives".
>
> If the code doesn't get too ugly I would vote to get the patch in.

There are many more leaks in there, the whole program (and the whole
tools/ directory really) is written with the assumption that you don't
have to free memory. That makes things a lot easier so it's worth it.