The whole point of printing the IGameStatisticsMgr::GetGameStatistics() return value was to check whether the pointer had been modified. So provide this information without including an ever changing value in the failure message.
Signed-off-by: Francois Gouget fgouget@codeweavers.com --- dlls/gameux/tests/gamestatistics.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/dlls/gameux/tests/gamestatistics.c b/dlls/gameux/tests/gamestatistics.c index d823af1aab2..8d4da4a0f4c 100644 --- a/dlls/gameux/tests/gamestatistics.c +++ b/dlls/gameux/tests/gamestatistics.c @@ -181,7 +181,8 @@ static void test_gamestatisticsmgr( void ) gs = (void *)0xdeadbeef; hr = IGameStatisticsMgr_GetGameStatistics(gsm, sExeName, GAMESTATS_OPEN_OPENONLY, &dwOpenResult, &gs); ok(hr == HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND), "GetGameStatistics returned unexpected value: 0x%08x\n", hr); - ok(gs == NULL, "Expected output pointer to be NULL, got %p\n", gs); + ok(gs == NULL, "Expected output pointer to be NULL, got %s\n", + (gs == (void *)0xdeadbeef ? "deadbeef" : "neither NULL nor deadbeef"));
/* now, allow them to be created */ hr = IGameStatisticsMgr_GetGameStatistics(gsm, sExeName, GAMESTATS_OPEN_OPENORCREATE, &dwOpenResult, &gs);
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=67194
Your paranoid android.
=== w1064v1809 (32 bit report) ===
gameux: gamestatistics.c:184: Test failed: Expected output pointer to be NULL, got neither NULL nor deadbeef
=== w1064v1809_2scr (32 bit report) ===
gameux: gamestatistics.c:184: Test failed: Expected output pointer to be NULL, got neither NULL nor deadbeef
=== w1064v1809_ar (32 bit report) ===
gameux: gamestatistics.c:184: Test failed: Expected output pointer to be NULL, got neither NULL nor deadbeef
=== w1064v1809_he (32 bit report) ===
gameux: gamestatistics.c:184: Test failed: Expected output pointer to be NULL, got neither NULL nor deadbeef
=== w1064v1809_ja (32 bit report) ===
gameux: gamestatistics.c:184: Test failed: Expected output pointer to be NULL, got neither NULL nor deadbeef
=== w1064v1809_zh_CN (32 bit report) ===
gameux: gamestatistics.c:184: Test failed: Expected output pointer to be NULL, got neither NULL nor deadbeef
=== w1064v1809 (64 bit report) ===
gameux: gamestatistics.c:184: Test failed: Expected output pointer to be NULL, got neither NULL nor deadbeef