Re: [PATCH] strmiids: Add evr interface GUIDS

[Alexandre Julliard]

Fabian Maurer  writes:
> @@ -18,12 +18,7 @@
> - Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
>
> */
>
> -import "unknwn.idl";
> -import "propidl.idl";
>  import "mfidl.idl";
> -import "mftransform.idl";
> -import "mediaobj.idl";
> -import "strmif.idl";

These are included by the MS header, so we need to have them too.

[PATCH] strmiids: Add evr interface GUIDS

[Fabian Maurer]

On Montag, 18. September 2017 09:26:30 CEST Alexandre Julliard wrote:
> Fabian Maurer  writes:
> > @@ -18,12 +18,7 @@
> > - Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301,
> >
> > USA
> >   */
> >
> > -import "unknwn.idl";
> > -import "propidl.idl";
> >
> > import "mfidl.idl";
> >
> > -import "mftransform.idl";
> > -import "mediaobj.idl";
> > -import "strmif.idl";
>
> These are included by the MS header, so we need to have them too.

What exactly is missing? We get them indirectly when including "mfidl.idl".

Regards,
Fabian Maurer

[PATCH] strmiids: Add evr interface GUIDS

[Alexandre Julliard]

Fabian Maurer  writes:
> On Montag, 18. September 2017 09:26:30 CEST Alexandre Julliard wrote:
> > Fabian Maurer  writes:
> > > @@ -18,12 +18,7 @@
> > > - Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301,
> > >
> > > USA
> > >   */
> > >
> > > -import "unknwn.idl";
> > > -import "propidl.idl";
> > >
> > > import "mfidl.idl";
> > >
> > > -import "mftransform.idl";
> > > -import "mediaobj.idl";
> > > -import "strmif.idl";
> >
> > These are included by the MS header, so we need to have them too.
>
> What exactly is missing? We get them indirectly when including "mfidl.idl".

Sure, unless an app does something strange like #define __mfidl_h__.
There have been such cases in the past, so it's better to play it safe.

[PATCH] strmiids: Add evr interface GUIDS

[Fabian Maurer]

> > > These are included by the MS header, so we need to have them too.
> >
> > What exactly is missing? We get them indirectly when including
> > "mfidl.idl".
>
> Sure, unless an app does something strange like #define __mfidl_h__.
> There have been such cases in the past, so it's better to play it safe.

Can't argue with that. I'll rework it, thanks for explaining.

Regards,
Fabian Maurer