Re: Alexander Nicolaysen Sørnes : comdlg32: PageSetupDlgA: Read margins from correct edit boxes.

[Vitaly Lipatov]

Hello,
I already posted the same patch to wine-patches one month ago:
http://www.winehq.org/pipermail/wine-patches/2007-November/046156.html
Why my patch was ignored? I am in some black list?

В сообщении от 8 декабря 2007 Alexandre Julliard написал(a):
> Module: wine
> Branch: master
> Commit: 51086b5513a436f51460d006f4fa7156e9d58a92
> URL:   
> http://source.winehq.org/git/wine.git/?a=commit;h=51086b5513a436f51460d006f
> 4fa7156e9d58a92
>
> Author: Alexander Nicolaysen Sørnes 
> Date:   Sat Dec  8 13:53:32 2007 +0100
>
> comdlg32: PageSetupDlgA: Read margins from correct edit boxes.
>
> dlls/comdlg32/printdlg.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/comdlg32/printdlg.c b/dlls/comdlg32/printdlg.c
> index e04e145..5baa90e 100644
> --- a/dlls/comdlg32/printdlg.c
> +++ b/dlls/comdlg32/printdlg.c
> @@ -2890,10 +2890,10 @@ PRINTDLG_PS_WMCommandA(
>      	GETVAL(id, pda->curdlg.rtMargin.left);
>    break;
>      case edt5:
> -
> GETVAL(id, pda->curdlg.rtMargin.right);
> - GETVAL(id, pda->curdlg.rtMargin.top);
> break;
> case edt6:
> -
> GETVAL(id, pda->curdlg.rtMargin.top);
> - GETVAL(id, pda->curdlg.rtMargin.right);
> break;
> case edt7:
> 	GETVAL(id, pda->curdlg.rtMargin.bottom);

Alexander Nicolaysen Sørnes : comdlg32: PageSetupDlgA: Read margins from correct edit boxes.

[Alexander Nicolaysen Sørnes]

On Saturday 08 December 2007 21:31:45 Vitaly Lipatov wrote:
> Hello,
> I already posted the same patch to wine-patches one month ago:
> http://www.winehq.org/pipermail/wine-patches/2007-November/046156.html
> Why my patch was ignored? I am in some black list?

I discovered the issue while working on PageDlgA/W.  Are you working on those, 
too?  Just so we don't duplicate work.

Alexander
> В сообщении от 8 декабря 2007 Alexandre Julliard написал(a):
> > Module: wine
> > Branch: master
> > Commit: 51086b5513a436f51460d006f4fa7156e9d58a92
> > URL:
> > http://source.winehq.org/git/wine.git/?a=commit;h=51086b5513a436f51460d00
> > 6f 4fa7156e9d58a92
> >
> > Author: Alexander Nicolaysen Sørnes 
> > Date:   Sat Dec  8 13:53:32 2007 +0100
> >
> > comdlg32: PageSetupDlgA: Read margins from correct edit boxes.
> >
> > dlls/comdlg32/printdlg.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/dlls/comdlg32/printdlg.c b/dlls/comdlg32/printdlg.c
> > index e04e145..5baa90e 100644
> > --- a/dlls/comdlg32/printdlg.c
> > +++ b/dlls/comdlg32/printdlg.c
> > @@ -2890,10 +2890,10 @@ PRINTDLG_PS_WMCommandA(
> >      	GETVAL(id, pda->curdlg.rtMargin.left);
> >    break;
> >      case edt5:
> > -
> > GETVAL(id, pda->curdlg.rtMargin.right);
> > - GETVAL(id, pda->curdlg.rtMargin.top);
> > break;
> > case edt6:
> > -
> > GETVAL(id, pda->curdlg.rtMargin.top);
> > - GETVAL(id, pda->curdlg.rtMargin.right);
> > break;
> > case edt7:
> > 	GETVAL(id, pda->curdlg.rtMargin.bottom);

Alexander Nicolaysen Sørnes : comdlg32: PageSetupDlgA: Read margins from correct edit boxes.

[Vitaly Lipatov]

В сообщении от 9 декабря 2007 Alexander Nicolaysen Sørnes написал(a):
> On Saturday 08 December 2007 21:31:45 Vitaly Lipatov wrote:
> > Hello,
> > I already posted the same patch to wine-patches one month ago:
> > http://www.winehq.org/pipermail/wine-patches/2007-November/046156.html
> > Why my patch was ignored? I am in some black list?
>
> I discovered the issue while working on PageDlgA/W.  Are you working on
> those, too?  Just so we don't duplicate work.

I did some works two years ago. Today I resend my patches to wine-patches with 
CC to you. Please pay attention to incorporate these changes in you works.