Re: [PATCH 2/2] user32: Implement BS_SPLITBUTTON and BS_DEFSPLITBUTTON.

[Nikolay Sivov]

On 06.02.2017 3:54, Shu Yokoyama wrote:
> Signed-off-by: Shu Yokoyama
>
> dlls/user32/button.c | 152 +++++++++++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 142 insertions(+), 10 deletions(-)
>
> diff --git a/dlls/user32/button.c b/dlls/user32/button.c
> index e85e30d..135fb1b 100644
> --- a/dlls/user32/button.c
> +++ b/dlls/user32/button.c
> @@ -29,6 +29,8 @@
> -
> - TODO
> - Styles
> -
> -
> - BS_COMMANDLINK
> -
> -
> - BS_DEFCOMMANDLINK
> -
> - BS_NOTIFY: is it complete?
> -
> - BS_RIGHTBUTTON: same as BS_LEFTTEXT
> -
>
> @@ -42,6 +44,8 @@
> -
> - BCM_GETTEXTMARGIN
> -
> - BCM_SETIMAGELIST
> -
> - BCM_SETTEXTMARGIN
> -
> -
> - BCM_SETSPLITINFO
> -
> -
> - BCM_GETSPLITINFO
> -
> - Notifications
> -
> - BCN_HOTITEMCHANGE
>
> @@ -61,6 +65,8 @@
> -
> - Button_GetTextMargin
> -
> - Button_SetImageList
> -
> - Button_SetTextMargin
> -
> -
> - Button_SetSplitInfo
> -
> -
> - Button_GetSplitInfo
> */
>
> #include <stdarg.h>
> @@ -73,6 +79,7 @@
>  #include "winbase.h"
>  #include "wingdi.h"
>  #include "controls.h"
> +#include "commctrl.h"
>  #include "win.h"
>  #include "user_private.h"
>  #include "wine/debug.h"
> @@ -101,6 +108,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(button);

Hi.

Patch has its own problems, but more importantly, that's not the way we
want v6 controls to be implemented. We need proper separation between
user32 and comctl32, with corresponding versioned classes being
registered at the right time, and proper classes used based on current
context.

[PATCH 2/2] user32: Implement BS_SPLITBUTTON and BS_DEFSPLITBUTTON.

[Shu Yokoyama]

> > Hi.
> >
> > Patch has its own problems, but more importantly, that's not the way we
> > want v6 controls to be implemented. We need proper separation between
> > user32 and comctl32, with corresponding versioned classes being
> > registered at the right time, and proper classes used based on current
> > context.

Thanks.
I found that those have to be implemented in dlls/comctl32/theme_button.c.

Now, comctl32 buttons are registered only if theme is active (theming.c:127).
However on Win7, if comctl32 v6 is loaded through SxS manifest,
the buttons are registered always, whether or not IsThemeActive() is true.
Then it might be necessary to separate comctl32.dll according to version.

----- Original Message -----
> > From: Nikolay Sivov 
> > To: wine-devel 
> > Cc: [e-mail]
> > Date: 2017-02-06 13:19:06
> > Subject: Re: [PATCH 2/2] user32: Implement BS_SPLITBUTTON and BS_DEFSPLITBUTTON.

[PATCH 2/2] user32: Implement BS_SPLITBUTTON and BS_DEFSPLITBUTTON.

[Nikolay Sivov]

On 06.02.2017 12:18, Shu Yokoyama wrote:
> > > Hi.
> > >
> > > Patch has its own problems, but more importantly, that's not the way we
> > > want v6 controls to be implemented. We need proper separation between
> > > user32 and comctl32, with corresponding versioned classes being
> > > registered at the right time, and proper classes used based on current
> > > context.
>
> Thanks.
> I found that those have to be implemented in dlls/comctl32/theme_button.c.
>
> Now, comctl32 buttons are registered only if theme is active (theming.c:127).
> However on Win7, if comctl32 v6 is loaded through SxS manifest,
> the buttons are registered always, whether or not IsThemeActive() is true.
> Then it might be necessary to separate comctl32.dll according to version.

Correct, theme_* files should go away eventually, and v6 classes should
not depend on whether theming is active or not. I don't need we
necessary need another separate comctl32 dll however.
> ----- Original Message -----
> > > From: Nikolay Sivov 
> > > To: wine-devel 
> > > Cc: [e-mail]
> > > Date: 2017-02-06 13:19:06
> > > Subject: Re: [PATCH 2/2] user32: Implement BS_SPLITBUTTON and BS_DEFSPLITBUTTON.

[PATCH 2/2] user32: Implement BS_SPLITBUTTON and BS_DEFSPLITBUTTON.

[Shu Yokoyama]

> > I found that those have to be implemented in dlls/comctl32/theme_button.c

theme_button.c is just for theming, v6 controls may have to be in a new file, possibly.