Re: schannel: Tests for Sp[Lsa,User]ModeInitialize and GetInfo

[James Hawkins]

On 4/24/07, Yuval Fledel  wrote:
>

+#if 0
+    /* NULL parameters: All 3 crash as of Windows XP */
+    status = pSpLsaModeInitialize(0x10000, NULL, &pTables, &cTables);
+    status = pSpLsaModeInitialize(0x10000, &Version, NULL, &cTables);
+    status = pSpLsaModeInitialize(0x10000, &Version, &pTables, NULL);
+#endif

We try to avoid #if 0/#endif constructs.  Just add a comment that
states that the function crashes in XP if any of those three params
are NULL.

schannel: Tests for Sp[Lsa,User]ModeInitialize and GetInfo

[Yuval Fledel]

On 24/04/07, James Hawkins  wrote:
> On 4/24/07, Yuval Fledel  wrote:
> +#if 0
> - /* NULL parameters: All 3 crash as of Windows XP */
> - status = pSpLsaModeInitialize(0x10000, NULL, &pTables, &cTables);
> - status = pSpLsaModeInitialize(0x10000, &Version, NULL, &cTables);
> - status = pSpLsaModeInitialize(0x10000, &Version, &pTables, NULL);
>
> +#endif
>
> We try to avoid #if 0/#endif constructs.  Just add a comment that
> states that the function crashes in XP if any of those three params
> are NULL.

Ok.

I was following the existing schannel tests example and the developers
guide (section 4.2).
> James Hawkins