How to add the Signed-off-by field in the git patch

[Dmitry Timoshkov]

Hi all,

since I personally asked that question and investigated a bit the subject,
here is some information that could be probably useful to someone else:

http://stackoverflow.com/questions/13457203/how-to-add-the-signed-off-by-fie...
http://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-g...
http://stackoverflow.com/questions/15015894/git-add-signed-off-by-line-using...
http://git-scm.com/docs/git-format-patch (CONFIGURATION section)

Personally I've chosen to add
[format]
    signOff = true
to git.config file.

[Aaryaman Vasishta]

Hi Dimitry,

Thanks! this will definitely help if this info is added to the wiki too.
Though it seems to be down right now. There's a discussion going on about
it on IRC right now.

Cheers,
Aaryaman

On Tue, Sep 22, 2015 at 4:10 PM, Dmitry Timoshkov  wrote:
> Hi all,
>
> since I personally asked that question and investigated a bit the subject,
> here is some information that could be probably useful to someone else:
>
> http://stackoverflow.com/questions/13457203/how-to-add-the-signed-off-by-fie...
>
> http://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-g...
>
> http://stackoverflow.com/questions/15015894/git-add-signed-off-by-line-using...
> http://git-scm.com/docs/git-format-patch (CONFIGURATION section)
>
> Personally I've chosen to add
> [format]
>         signOff = true
> to git.config file.
>
> --
> Dmitry.

[Alex Henrie]

I just updated http://wiki.winehq.org/SubmittingPatches with
instructions on how to include the Signed-off-by line. I will update
the GitWine page soon. Please feel free to improve the wiki further.

-Alex

[Frédéric Delanoy]

On Tue, Sep 22, 2015 at 5:02 PM, Alex Henrie  wrote:
> I just updated http://wiki.winehq.org/SubmittingPatches with
> instructions on how to include the Signed-off-by line. I will update
> the GitWine page soon. Please feel free to improve the wiki further.
>
> -Alex

In the SubmittingPatches page, you say one should sign-off one's own
patches. Isn't that rather redundant when you are the author?

I believe Signed-off is for patch reviewers, not main authors.

Frédéric

[Michael Stefaniuc]

On 09/28/2015 12:46 PM, Frédéric Delanoy wrote:
> On Tue, Sep 22, 2015 at 5:02 PM, Alex Henrie  wrote:
> > I just updated http://wiki.winehq.org/SubmittingPatches with
> > instructions on how to include the Signed-off-by line. I will update
> > the GitWine page soon. Please feel free to improve the wiki further.
> >
> > -Alex
>
> In the SubmittingPatches page, you say one should sign-off one's own
> patches. Isn't that rather redundant when you are the author?

Not redundant at all. The author signing-off just signals that the patch
is ready for upstream and that the author takes responsibility for it.
Without a sign-off it might be just a hack or a RFC or what not.
> I believe Signed-off is for patch reviewers, not main authors.

It is for both author(s) and reviewers.

bye
    michael