Re: [PATCH] shell32/ebrowser: Added IOleWindow stub for IExplorerBrowser

[Huw Davies]

On Mon, Apr 24, 2017 at 08:50:09AM +0300, Nikolay Sivov wrote:
> Signed-off-by: Nikolay Sivov
>
> dlls/shell32/ebrowser.c       | 56 +++++++++++++++++++++++++++++++++++++++++++
>  dlls/shell32/tests/ebrowser.c |  2 +-
>  2 files changed, 57 insertions(+), 1 deletion(-)
>
> diff --git a/dlls/shell32/ebrowser.c b/dlls/shell32/ebrowser.c
> index bbccf88814..77c727a5ec 100644
> --- a/dlls/shell32/ebrowser.c
> +++ b/dlls/shell32/ebrowser.c
> @@ -56,6 +56,7 @@ typedef struct _ExplorerBrowserImpl {
>      IShellBrowser     IShellBrowser_iface;
>      ICommDlgBrowser3  ICommDlgBrowser3_iface;
>      IObjectWithSite   IObjectWithSite_iface;
> - IOleWindow        IOleWindow_iface;
> INameSpaceTreeControlEvents INameSpaceTreeControlEvents_iface;
> IInputObject      IInputObject_iface;
> LONG ref;

IShellBrowser inherits IOleWindow, so you don't need this.

Huw.

[PATCH] shell32/ebrowser: Added IOleWindow stub for IExplorerBrowser

[Nikolay Sivov]

On 24.04.2017 10:33, Huw Davies wrote:
> On Mon, Apr 24, 2017 at 08:50:09AM +0300, Nikolay Sivov wrote:
> > Signed-off-by: Nikolay Sivov
> >
> > dlls/shell32/ebrowser.c       | 56 +++++++++++++++++++++++++++++++++++++++++++
> >  dlls/shell32/tests/ebrowser.c |  2 +-
> >  2 files changed, 57 insertions(+), 1 deletion(-)
> >
> > diff --git a/dlls/shell32/ebrowser.c b/dlls/shell32/ebrowser.c
> > index bbccf88814..77c727a5ec 100644
> > --- a/dlls/shell32/ebrowser.c
> > +++ b/dlls/shell32/ebrowser.c
> > @@ -56,6 +56,7 @@ typedef struct _ExplorerBrowserImpl {
> >      IShellBrowser     IShellBrowser_iface;
> >      ICommDlgBrowser3  ICommDlgBrowser3_iface;
> >      IObjectWithSite   IObjectWithSite_iface;
> > - IOleWindow        IOleWindow_iface;
> > INameSpaceTreeControlEvents INameSpaceTreeControlEvents_iface;
> > IInputObject      IInputObject_iface;
> > LONG ref;
>
> IShellBrowser inherits IOleWindow, so you don't need this.

That's even better, thanks.
> Huw.