Re: [tools] add winecfg to XDG menus

[Marcus Meissner]

On Tue, May 15, 2007 at 07:36:38AM +0200, Damjan Jovanovic wrote:
> Changelog:
> - When installing wine, add an entry for winecfg to the XDG menus
>
> Damjan Jovanovic
> diff -Nur a/tools/Makefile.in b/tools/Makefile.in
> --- a/tools/Makefile.in	2007-05-03 08:46:44.000000000 +0200
> +++ b/tools/Makefile.in	2007-05-14 21:59:17.646137077 +0200
> @@ -82,7 +82,11 @@
>  install install-lib:: wineprefixcreate $(INSTALLDIRS)
>    $(INSTALL_SCRIPT) wineprefixcreate $(DESTDIR)$(bindir)/wineprefixcreate
>    $(INSTALL_DATA) $(SRCDIR)/wine.inf $(DESTDIR)$(datadir)/wine/wine.inf
> - mkdir -p /etc/xdg/menus &> /dev/null || true
> - mkdir -p ~/.config/menus/applications-merged
> - if ! $(INSTALL_DATA) $(SRCDIR)/wine.menu /etc/xdg/menus &> /dev/null; then $(INSTALL_DATA) $(SRCDIR)/wine.menu ~/.config/menus/applications-merged; fi

Please do not use ~. You are not supposed to put stuff into any
kind of $HOMEs.

Please use $(DESTDIR) for global paths.

Ciao, Marcus

[tools] add winecfg to XDG menus

[Damjan Jovanovic]

On 5/15/07, Marcus Meissner  wrote:
> On Tue, May 15, 2007 at 07:36:38AM +0200, Damjan Jovanovic wrote:
> > Changelog:
> > - When installing wine, add an entry for winecfg to the XDG menus
> >
> > Damjan Jovanovic
> > diff -Nur a/tools/Makefile.in b/tools/Makefile.in
> > --- a/tools/Makefile.in       2007-05-03 08:46:44.000000000 +0200
> > +++ b/tools/Makefile.in       2007-05-14 21:59:17.646137077 +0200
> > @@ -82,7 +82,11 @@
> >  install install-lib:: wineprefixcreate $(INSTALLDIRS)
> >       $(INSTALL_SCRIPT) wineprefixcreate $(DESTDIR)$(bindir)/wineprefixcreate
> >       $(INSTALL_DATA) $(SRCDIR)/wine.inf $(DESTDIR)$(datadir)/wine/wine.inf
> > -
> > mkdir -p /etc/xdg/menus &> /dev/null || true
> > -
> > mkdir -p ~/.config/menus/applications-merged
> > -
> > if ! $(INSTALL_DATA) $(SRCDIR)/wine.menu /etc/xdg/menus &> /dev/null; then $(INSTALL_DATA) $(SRCDIR)/wine.menu ~/.config/menus/applications-merged; fi
>
> Please do not use ~. You are not supposed to put stuff into any
> kind of $HOMEs.

What about menus, they have to either go into /etc/xdg/menus or
~/.config/menus/applications-merged?
> Please use $(DESTDIR) for global paths.
>
> Ciao, Marcus