It's preferred to have original author submitting his own work. Christian, ping?
Usually Sebastian send my patches upstream but I said to Alistair he can send my semantics patches upstream if Sebastian is too busy or has other priorities.
2015-09-10 10:58 GMT+02:00 Nikolay Sivov bunglehead@gmail.com:
It's preferred to have original author submitting his own work. Christian, ping?
On Thursday, September 10, 2015, Christian Costa titan.costa@gmail.com wrote:
Usually Sebastian send my patches upstream but I said to Alistair he can send my semantics patches upstream if Sebastian is too busy or has other priorities.
Usually Sebastian adds a From: field in the email body so the right person get named in git. Unless of course the patch was changed by the person sending.
On 10 September 2015 at 15:41, Bruno Jesus 00cpxxx@gmail.com wrote:
Usually Sebastian adds a From: field in the email body so the right person get named in git. Unless of course the patch was changed by the person sending.
In principle the attached patch has a correct "From:" (though seriously, learn to use git send-email), but the point is of course that Sebastian isn't the author of the patch either. Other considerations aside, the author supposedly being unable to figure out how to send a patch to a mailing list doesn't inspire a lot of confidence that the patch is correct.
"the author supposedly being unable to figure out how to send a patch to a mailing list ...". Are you referring to me?
2015-09-10 15:55 GMT+02:00 Henri Verbeet hverbeet@gmail.com:
On 10 September 2015 at 15:41, Bruno Jesus 00cpxxx@gmail.com wrote:
Usually Sebastian adds a From: field in the email body so the right
person
get named in git. Unless of course the patch was changed by the person sending.
In principle the attached patch has a correct "From:" (though seriously, learn to use git send-email), but the point is of course that Sebastian isn't the author of the patch either. Other considerations aside, the author supposedly being unable to figure out how to send a patch to a mailing list doesn't inspire a lot of confidence that the patch is correct.
On 10 September 2015 at 16:36, Christian Costa titan.costa@gmail.com wrote:
"the author supposedly being unable to figure out how to send a patch to a mailing list ...". Are you referring to me?
In this specific case, yes, but it applies in general.
I could learn for sure but I feel it's beyond my skills.
2015-09-10 16:42 GMT+02:00 Henri Verbeet hverbeet@gmail.com:
On 10 September 2015 at 16:36, Christian Costa titan.costa@gmail.com wrote:
"the author supposedly being unable to figure out how to send a patch to a mailing list ...". Are you referring to me?
In this specific case, yes, but it applies in general.
Hi Christian,
I feel so sorry to you if there is any words look not friendly to you, maybe there is nothing I can help right here, but I'd like to appreciate you for your contribution to Wine, thanks ;-)
-
Bruno Jesus -
Christian Costa -
Henri Verbeet -
Nikolay Sivov -
Qian Hong