Hi Nowres, did you run the regedit tests, cd programs/regedit/tests make test after that change? Here it fails with regedit.c:384: Test failed: regedit not available, skipping regedit tests ( log at http://buildbot.kegel.com/builders/runtests/builds/2 ) You might need to fully implement the /S switch for regedit and use it from the tests before you can add the confirmation dialog to regedit. - Dan
On Wed, Aug 17, 2011 at 8:17 AM, Dan Kegel dank@kegel.com wrote:
Hi Nowres, did you run the regedit tests, cd programs/regedit/tests make test after that change? Here it fails with regedit.c:384: Test failed: regedit not available, skipping regedit tests ( log at http://buildbot.kegel.com/builders/runtests/builds/2 ) You might need to fully implement the /S switch for regedit and use it from the tests before you can add the confirmation dialog to regedit.
Ah, of course, the tests already use /S, since they pass on windows. So you just need to make your dialog not show up when /S is given.
On 17/08/2011 15:19, Dan Kegel wrote:
On Wed, Aug 17, 2011 at 8:17 AM, Dan Kegeldank@kegel.com wrote:
Hi Nowres, did you run the regedit tests, cd programs/regedit/tests make test after that change? Here it fails with regedit.c:384: Test failed: regedit not available, skipping regedit tests ( log at http://buildbot.kegel.com/builders/runtests/builds/2 ) You might need to fully implement the /S switch for regedit and use it from the tests before you can add the confirmation dialog to regedit.
Ah, of course, the tests already use /S, since they pass on windows. So you just need to make your dialog not show up when /S is given.
Ok Dan, thank you for the hint
On Wed, 2011-08-17 at 08:19 -0700, Dan Kegel wrote:
On Wed, Aug 17, 2011 at 8:17 AM, Dan Kegel dank@kegel.com wrote:
Hi Nowres, did you run the regedit tests, cd programs/regedit/tests make test after that change? Here it fails with regedit.c:384: Test failed: regedit not available, skipping regedit tests ( log at http://buildbot.kegel.com/builders/runtests/builds/2 ) You might need to fully implement the /S switch for regedit and use it from the tests before you can add the confirmation dialog to regedit.
Ah, of course, the tests already use /S, since they pass on windows. So you just need to make your dialog not show up when /S is given.
I updated the patch. can you please check it?
-
Dan Kegel -
Nowres Rafid