-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi again!
I have some more format nitpicks below.
As far as the big picture is concerned there is also a software conversion path in dlls/wined3d/surface.c. Search the file for d3dfmt_converter_desc and you should find the right place. You don't have to submit a patch for that unless you know an application that needs it though; I'm just making you aware of it.
Am 2014-02-11 12:14, schrieb Martin Storsjo:
- switch(textype)
You're missing a space here. As far as I can see the other places in this patch are correct, but it doesn't hurt to double-check with grep or something.
(I really hope the testbot can one day take care of this...)
case GL_TEXTURE_2D: tex = "2D"; break;
Please make this case GL_TEXTURE_2D: tex = "2D"; break;
etc
* When reading from rectangle textures, keep in mind thatthe input y coordinates + * go from 0 to d3d_height, whereas the opengl texture height is 1.5 * d3d_height + */
Comment closing should go next to the last line of text. Also add proper interpunctuation at the last sentence of a comment.
This applies to a few more places in this patch, and most likely the other patches.
-
Stefan Dösinger