Re: cabinent: add a comment about parm passing

[James Hawkins]

On 6/27/07, Jeff Latimer  wrote:
> Coverity CID 43 Forward_Null is false.  This adds a comment explaining
> the NULL pass is ok.

Why do we need a comment for that?

cabinent: add a comment about parm passing

[Jeff L]

James Hawkins wrote:
> On 6/27/07, Jeff Latimer  wrote:
> > Coverity CID 43 Forward_Null is false.  This adds a comment explaining
> > the NULL pass is ok.
>
> Why do we need a comment for that?

Mainly because the logic is a bit difficult.  It depends on the length 
being 0 to terminate the for loop and prevent the null reference.  It is 
not obvious and easily missed the first time through. Wine has a number 
of things like that and more comments would make it quicker and safer to 
works with.

cabinent: add a comment about parm passing

[Alexandre Julliard]

Jeff L  writes:
> Mainly because the logic is a bit difficult.  It depends on the length
> being 0 to terminate the for loop and prevent the null reference.  It
> is not obvious and easily missed the first time through. Wine has a
> number of things like that and more comments would make it quicker and
> safer to works with.

No, the proper way is to fix the code so that it's understandable.
In this specific case you can get rid of the realloc function, it's
useless.