Re: riched20/tests: Mark behaviour at 120 dpi as broken

[James Mckenzie]

Andre:

My computer is set up for 125 dpi (Large Fonts on WindowsXP).  Should we be testing for this as well?  This should give different results than what is stated here.  Maybe there is a better way to test this than using a fixed value of 39 in the ok comparision.

James McKenzie

-----Original Message-----
> From: André Hentschel 
> Sent: Dec 9, 2010 11:38 AM
> To: wine-patches 
> Subject: riched20/tests: Mark behaviour at 120 dpi as broken
> comparison to 96 dpi can be found at http://test.winehq.org/data/23906816d87795c363f0199f33ff70f2732c6ab5/index_W...
>
> dlls/riched20/tests/editor.c |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/dlls/riched20/tests/editor.c b/dlls/riched20/tests/editor.c
> index efd2023..5321d07 100644
> --- a/dlls/riched20/tests/editor.c
> +++ b/dlls/riched20/tests/editor.c
> @@ -6082,7 +6082,9 @@ static void test_EM_CHARFROMPOS(void)
>     point.x = 1000;
>     point.y = 40;
>     result = SendMessage(hwnd, EM_CHARFROMPOS, 0, (LPARAM)&point);
> - todo_wine ok(result == 39, "expected character index of 39 but got %d\n", result);
> -
>
> todo_wine ok(result == 39,
> -
>             broken(result == 34) /* 120 dpi */,
> -
>             "expected character index of 39 but got %d\n", result);
>
> point.x = 1000;
>   point.y = -1;
>
> --
>
> Best Regards, André Hentschel