What macOS SDK is being tested against on gitlab?

[Dean Greer]

Hi everyone,

I’d just tried to build the current git and winemac.drv is failing building
on macOS Monterey with the latest 12.3 SDK so I’m assuming the gitlab test
is using an older macOS SDK?

[Brendan Shanks]

> On Sep 22, 2022, at 7:39 AM, Dean Greer  wrote:
>
> Hi everyone,
>
> I’d just tried to build the current git and winemac.drv is failing building on macOS Monterey with the latest 12.3 SDK so I’m assuming the gitlab test is using an older macOS SDK?

Hi Dean,

What failure are you seeing? I just built current git on Monterey with Xcode 13.4.1 and didn’t get any errors.

Brendan

[Dean Greer]

Hi Brendan,

Unfortunately I’m currently working so away from my mac, but I believe it
was something about an undeclared identifier?

As for the other question any clue what macOS SDK is being used on the
gitlab CI?, as it would be handy to know that upstream tests against.

On Thu, Sep 22, 2022 at 11:30 AM Brendan Shanks 
wrote:
> > On Sep 22, 2022, at 7:39 AM, Dean Greer  wrote:
> >
> > Hi everyone,
> >
> > I’d just tried to build the current git and winemac.drv is failing
>
> building on macOS Monterey with the latest 12.3 SDK so I’m assuming the
> gitlab test is using an older macOS SDK?
>
> Hi Dean,
>
> What failure are you seeing? I just built current git on Monterey with
> Xcode 13.4.1 and didn’t get any errors.
>
> Brendan

[Alexandre Julliard]

Dean Greer  writes:
> Hi Brendan,
>
> Unfortunately I’m currently working so away from my mac, but I believe it was something about an undeclared identifier?
>
> As for the other question any clue what macOS SDK is being used on the gitlab CI?, as it would be handy to know that upstream tests against.

As far as I can tell it's using 12.3.

[Dean Greer]

Hi Alexandre,

Good to know, is that a self hosted CI? As it would be nice to have a
better idea of what’s been installed.

As for the build issue I’m not sure what the hell that’s all about when
even my actions runs build it without issue…, this system was recently
upgraded so maybe need to manually wipe Xcode/Command Line Tools and clean
install it again

On Thu, Sep 22, 2022 at 12:32 PM Alexandre Julliard 
wrote:
> Dean Greer  writes:
> > Hi Brendan,
> >
> > Unfortunately I’m currently working so away from my mac, but I believe
>
> it was something about an undeclared identifier?
> > As for the other question any clue what macOS SDK is being used on the
>
> gitlab CI?, as it would be handy to know that upstream tests against.
>
> As far as I can tell it's using 12.3.
>
> --
> Alexandre Julliard
> [e-mail]

[Dean Greer]

Found the problem I’d had with wine-git, for some reason the i386 build
only used the 10.13 SDK for configure and then default back to 12.3 SDK for
the actual build.

On Thu, Sep 22, 2022 at 4:50 PM Dean Greer  wrote:
> Hi Alexandre,
>
> Good to know, is that a self hosted CI? As it would be nice to have a
> better idea of what’s been installed.
>
> As for the build issue I’m not sure what the hell that’s all about when
> even my actions runs build it without issue…, this system was recently
> upgraded so maybe need to manually wipe Xcode/Command Line Tools and clean
> install it again
>
> On Thu, Sep 22, 2022 at 12:32 PM Alexandre Julliard 
> wrote:
> > Dean Greer  writes:
> > > Hi Brendan,
> > >
> > > Unfortunately I’m currently working so away from my mac, but I believe
> >
> > it was something about an undeclared identifier?
> > > As for the other question any clue what macOS SDK is being used on the
> >
> > gitlab CI?, as it would be handy to know that upstream tests against.
> >
> > As far as I can tell it's using 12.3.
> >
> > --
> > Alexandre Julliard
> > [e-mail]

[Alexandre Julliard]

Dean Greer  writes:
> Hi Alexandre,
>
> Good to know, is that a self hosted CI? As it would be nice to have a better idea of what’s been installed.

Yes, it's a dedicated Mac Mini that we have setup for that purpose,
currently running macOS 12.5.1.  I installed a number of Homebrew
packages that are necessary for building Wine. If there are specific
queries you'd like me to run on that box I'd be happy to.

[Dean Greer]

Hi Alexandre,
> Yes, it's a dedicated Mac Mini that we have setup for that purpose,

currently running macOS 12.5.1.  I installed a number of Homebrew
packages that are necessary for building Wine. If there are specific
queries you'd like me to run on that box I'd be happy to.

The minimum packages would be;

# build deps
          brew install  bison \
                              pkg-config \
                              mingw-w64

# runtime deps
          brew install  freetype \
                              gphoto2 \
                              gst-plugins-base \
                              krb5 \
                              mingw-w64 \
                              molten-vk \
                              sdl2

# casks
          brew install --cask xquartz

PATH would need to be appended with $(brew --prefix krb5)/bin

A copy of MacOSX10.13.sdk from Xcode9.3 (or later version of Xcode9) placed
into /Library/Developer/CommandLineTools/SDKs/ then the testbot could also
test compiling i386 wine.

configure/make wine64 then set the following before running configure for
i386;
 export SDKROOT="/Library/Developer/CommandLineTools/SDKs/MacOSX10.13.sdk"
 export PKG_CONFIG_LIBDIR="/opt/X11/lib/pkgconfig:/opt/X11/share/pkgconfig"

That would at least cover the basics for an i386 build without needing a
legacy macOS runner

I've not included libusb as that causes wine(64)-preloader to take over usb
devices according to user feedback

On Fri, Sep 23, 2022 at 8:03 AM Alexandre Julliard 
wrote:
> Dean Greer  writes:
> > Hi Alexandre,
> >
> > Good to know, is that a self hosted CI? As it would be nice to have a
>
> better idea of what’s been installed.
>
> Yes, it's a dedicated Mac Mini that we have setup for that purpose,
> currently running macOS 12.5.1.  I installed a number of Homebrew
> packages that are necessary for building Wine. If there are specific
> queries you'd like me to run on that box I'd be happy to.
>
> --
> Alexandre Julliard
> [e-mail]

[Dean Greer]

Forgotten one additional export for the i386 side

Unless this is set to 10.14 or lower there ends up being weird linker
issues for the i386 binaries (this includes CX 32on64 sources)
export MACOSX_DEPLOYMENT_TARGET="10.9"

On Fri, Sep 23, 2022 at 10:04 AM Dean Greer  wrote:
> Hi Alexandre,
> > Yes, it's a dedicated Mac Mini that we have setup for that purpose,
>
> currently running macOS 12.5.1.  I installed a number of Homebrew
> packages that are necessary for building Wine. If there are specific
> queries you'd like me to run on that box I'd be happy to.
>
> The minimum packages would be;
>       # build deps
>       brew install  bison \
>                           pkg-config \
>                           mingw-w64
>
>       # runtime deps
>       brew install  freetype \
>                           gphoto2 \
>                           gst-plugins-base \
>                           krb5 \
>                           mingw-w64 \
>                           molten-vk \
>                           sdl2
>
>       # casks
>       brew install --cask xquartz
>
> PATH would need to be appended with $(brew --prefix krb5)/bin
>
> A copy of MacOSX10.13.sdk from Xcode9.3 (or later version of Xcode9)
> placed into /Library/Developer/CommandLineTools/SDKs/ then the testbot
> could also test compiling i386 wine.
>
> configure/make wine64 then set the following before running configure for
> i386;
>  export SDKROOT="/Library/Developer/CommandLineTools/SDKs/MacOSX10.13.sdk"
>  export PKG_CONFIG_LIBDIR="/opt/X11/lib/pkgconfig:/opt/X11/share/pkgconfig"
>
> That would at least cover the basics for an i386 build without needing a
> legacy macOS runner
>
> I've not included libusb as that causes wine(64)-preloader to take over
> usb devices according to user feedback
>
> On Fri, Sep 23, 2022 at 8:03 AM Alexandre Julliard 
> wrote:
> > Dean Greer  writes:
> > > Hi Alexandre,
> > >
> > > Good to know, is that a self hosted CI? As it would be nice to have a
> >
> > better idea of what’s been installed.
> >
> > Yes, it's a dedicated Mac Mini that we have setup for that purpose,
> > currently running macOS 12.5.1.  I installed a number of Homebrew
> > packages that are necessary for building Wine. If there are specific
> > queries you'd like me to run on that box I'd be happy to.
> >
> > --
> > Alexandre Julliard
> > [e-mail]

[Alexandre Julliard]

Dean Greer  writes:
> Hi Alexandre,
> > Yes, it's a dedicated Mac Mini that we have setup for that purpose,
>
> currently running macOS 12.5.1.  I installed a number of Homebrew
> packages that are necessary for building Wine. If there are specific
> queries you'd like me to run on that box I'd be happy to.
>
> The minimum packages would be;
>       # build deps
>       brew install  bison \
>                           pkg-config \
>                           mingw-w64
>
>       # runtime deps
>       brew install  freetype \
>                           gphoto2 \
>                           gst-plugins-base \
>                           krb5 \
>                           mingw-w64 \
>                           molten-vk \
>                           sdl2
>
>       # casks
>       brew install --cask xquartz
>
> PATH would need to be appended with $(brew --prefix krb5)/bin
>
> A copy of MacOSX10.13.sdk from Xcode9.3 (or later version of Xcode9) placed into /Library/Developer/CommandLineTools/SDKs/ then the testbot could also test compiling i386 wine.
>
> configure/make wine64 then set the following before running configure for i386;
>  export SDKROOT="/Library/Developer/CommandLineTools/SDKs/MacOSX10.13.sdk"
>  export PKG_CONFIG_LIBDIR="/opt/X11/lib/pkgconfig:/opt/X11/share/pkgconfig"
>
> That would at least cover the basics for an i386 build without needing a legacy macOS runner

At this point I don't think we care about testing i386 builds for
macOS. We should soon have a way of building the 32-bit PE dlls as part
of the 64-bit build, which should be the default going forward.

[Dean Greer]

Hi Alexandre,
> At this point I don't think we care about testing i386 builds for

macOS. We should soon have a way of building the 32-bit PE dlls as part
of the 64-bit build, which should be the default going forward.

Was this implementation confirmed to also work on legacy macOS versions
that still natively support 32Bit?

More of a concern is recent macOS SDKs are marking functions as
depreciated, when those get swapped out with the newer version (usually
just renamed), if the old name isn’t mapped building against older SDKs
will be broken.

Keeping wine(64) buildable against MacOSX10.13.SDK would be the minimum for
comparability's sake, still being able to build against MacOSX10.11 (or
MacOSX10.10.SDK final revision) would be more ideal at least being
buildable against 10.13 would be required to still support the 32Bit wine
loader.

On Fri, Sep 23, 2022 at 10:43 AM Alexandre Julliard 
wrote:
> Dean Greer  writes:
> > Hi Alexandre,
> > > Yes, it's a dedicated Mac Mini that we have setup for that purpose,
> >
> > currently running macOS 12.5.1.  I installed a number of Homebrew
> > packages that are necessary for building Wine. If there are specific
> > queries you'd like me to run on that box I'd be happy to.
> >
> > The minimum packages would be;
> >       # build deps
> >       brew install  bison \
> >                           pkg-config \
> >                           mingw-w64
> >
> >       # runtime deps
> >       brew install  freetype \
> >                           gphoto2 \
> >                           gst-plugins-base \
> >                           krb5 \
> >                           mingw-w64 \
> >                           molten-vk \
> >                           sdl2
> >
> >       # casks
> >       brew install --cask xquartz
> >
> > PATH would need to be appended with $(brew --prefix krb5)/bin
> >
> > A copy of MacOSX10.13.sdk from Xcode9.3 (or later version of Xcode9)
>
> placed into /Library/Developer/CommandLineTools/SDKs/ then the testbot
> could also test compiling i386 wine.
> > configure/make wine64 then set the following before running configure
>
> for i386;
> > export
>
> SDKROOT="/Library/Developer/CommandLineTools/SDKs/MacOSX10.13.sdk"
> > export
>
> PKG_CONFIG_LIBDIR="/opt/X11/lib/pkgconfig:/opt/X11/share/pkgconfig"
> > That would at least cover the basics for an i386 build without needing a
>
> legacy macOS runner
>
> At this point I don't think we care about testing i386 builds for
> macOS. We should soon have a way of building the 32-bit PE dlls as part
> of the 64-bit build, which should be the default going forward.
>
> --
> Alexandre Julliard
> [e-mail]