Re: [PATCH 3/5] msi: Implement UI messages for dialogs.

[Alexandre Julliard]

Zebediah Figura  writes:
> Signed-off-by: Zebediah Figura
>
> dlls/msi/action.c        |  74 +++++++++++++--------------
>  dlls/msi/custom.c        |   2 +-
>  dlls/msi/dialog.c        |  55 +++++++++++++++++++-
>  dlls/msi/msi.rc          |   3 +-
>  dlls/msi/msipriv.h       |   1 +
>  dlls/msi/package.c       |   7 +++
>  dlls/msi/resource.h      |   1 +
>  dlls/msi/tests/package.c | 130 +++++++++++++++++++++++++++++++++++++++++++++--
>  8 files changed, 225 insertions(+), 48 deletions(-)

This is causing the test to leave behind a winetest-package.msi file.

[PATCH 3/5] msi: Implement UI messages for dialogs.

[Zebediah Figura]

On 07/06/2017 03:47 PM, Alexandre Julliard wrote:
> Zebediah Figura  writes:
> > Signed-off-by: Zebediah Figura
> >
> > dlls/msi/action.c        |  74 +++++++++++++--------------
> >   dlls/msi/custom.c        |   2 +-
> >   dlls/msi/dialog.c        |  55 +++++++++++++++++++-
> >   dlls/msi/msi.rc          |   3 +-
> >   dlls/msi/msipriv.h       |   1 +
> >   dlls/msi/package.c       |   7 +++
> >   dlls/msi/resource.h      |   1 +
> >   dlls/msi/tests/package.c | 130 +++++++++++++++++++++++++++++++++++++++++++++--
> >   8 files changed, 225 insertions(+), 48 deletions(-)
>
> This is causing the test to leave behind a winetest-package.msi file.

If I'm not mistaken, that's because closing the package handle doesn't 
destroy it. That is what the next patch in the series should fix, 
although it evidently has its own problems (and should have been ordered 
before this patch anyway.)