On Tue, Apr 24, 2001 at 09:33:16PM +0200, Marcus Meissner wrote:
Hi,
Changelog: Drop SYSLEVEL checks from relay debugging, since they break debugging builtin GDI dlls.
Hmm, do we really want to do this ? (I know it's already been applied)
Shouldn't we create a different SYSLEVEL_CheckNotLevel_unenforced() function instead which simply doesn't call DebugBreak() ?
That way we don't lose the important information about possible syslevel violations.
Syslevel violations are an *ongoing* problem. They are not simply "solved". OTOH I could take Alexandre's cvs commit as his firm promise to go through every future patch line by line to check for syslevel mishaps/omissions ;-)
Oh yeah, and in case you didn't notice: it's me again complaining about yet another silencing ;-)
This patch is not even "too early", it's simply "wrong" IMHO, as it is an ongoing problem (I did mention this before, didn't I ? :).
Sorry for me being of such an opposing nature ;-)
On Wed, Apr 25, 2001 at 01:25:11PM +0200, Andreas Mohr wrote:
On Tue, Apr 24, 2001 at 09:33:16PM +0200, Marcus Meissner wrote:
Hi,
Changelog: Drop SYSLEVEL checks from relay debugging, since they break debugging builtin GDI dlls.
Hmm, do we really want to do this ? (I know it's already been applied)
Shouldn't we create a different SYSLEVEL_CheckNotLevel_unenforced() function instead which simply doesn't call DebugBreak() ?
That way we don't lose the important information about possible syslevel violations.
Syslevel violations are an *ongoing* problem. They are not simply "solved". OTOH I could take Alexandre's cvs commit as his firm promise to go through every future patch line by line to check for syslevel mishaps/omissions ;-)
Oh yeah, and in case you didn't notice: it's me again complaining about yet another silencing ;-)
This patch is not even "too early", it's simply "wrong" IMHO, as it is an ongoing problem (I did mention this before, didn't I ? :).
Oh, then implement a way to let it enabled _AND_ make it possible to relay debug wineps, where pCreateDC must be called with GDI (DC) lock held all the time (and which does hundreds of API calls into other dlls).
Ciao, Marcus
On Wed, Apr 25, 2001 at 02:11:09PM +0200, Marcus Meissner wrote:
On Wed, Apr 25, 2001 at 01:25:11PM +0200, Andreas Mohr wrote:
Oh yeah, and in case you didn't notice: it's me again complaining about yet another silencing ;-)
This patch is not even "too early", it's simply "wrong" IMHO, as it is an ongoing problem (I did mention this before, didn't I ? :).
Oh, then implement a way to let it enabled _AND_ make it possible to relay debug wineps, where pCreateDC must be called with GDI (DC) lock held all the time (and which does hundreds of API calls into other dlls).
Hmm, what's the problem ?
AFAICS the problem is that these calls cause trouble because of the DebugBreak(). So just add another function without DebugBreak(). OTOH the real issue seems to be that we can't decide which function to use then, the enforced or unenforced one. So just drop (i.e.: comment out !) the DebugBreak() completely instead.
Still much better than not showing anything at all.
Hi again,
if we change the behaviour of that stuff (well, it's already changed), then this should also fix Win16 printer drivers, right ?
So it seems wineps has just the very same problems as Win16 printer drivers...
-
Andreas Mohr -
Marcus Meissner