Re: 0001-server-main.c-fixed-command-line-parsing-using-GNU-getopt

[Dmitry Timoshkov]

"Srivatsa Kanchi, R"  wrote:
> replaced the custom 'parse_args' function with GNU getopt

And what's wrong with current parser, except it being custom?
> applied some coding style to limit code 80 characters /line

Please leave existing style alone, even if you don't like it.

0001-server-main.c-fixed-command-line-parsing-using-GNU-getopt

[Srivatsa Kanchi, R]

Hi Dmitry,

There is nothing wrong with the exiting one; But there is a fixme saying
'should be using getopt', so i did it.

and regarding coding style,  they are mentioned in the developer's guide
and i tried to follow it

i love this project very much and looking forward to give more
contributions where ever possible

On Tue, 2007-03-06 at 00:52 +0800, Dmitry Timoshkov wrote:
> "Srivatsa Kanchi, R"  wrote:
> > replaced the custom 'parse_args' function with GNU getopt
>
> And what's wrong with current parser, except it being custom?
> > applied some coding style to limit code 80 characters /line
>
> Please leave existing style alone, even if you don't like it.

0001-server-main.c-fixed-command-line-parsing-using-GNU-getopt

[Dmitry Timoshkov]

"Srivatsa Kanchi, R"  wrote:
> There is nothing wrong with the exiting one; But there is a fixme saying
> 'should be using getopt', so i did it.

That FIXME tells 'probably'. I'd argue that using getopt in wineserver is
an overkill since its command line syntax is very simple.
> and regarding coding style,  they are mentioned in the developer's guide
> and i tried to follow it

Coding style mentioned in the developer's guide is related to the *new* code,
not an existing one.

0001-server-main.c-fixed-command-line-parsing-using-GNU-getopt

[Srivatsa Kanchi, R]

sure its an overkill to have an advanced Command line parser at this
moment; but, wine is still not a finished product and it may get more
options added later on

i picked up this because it seemed very easy to fix and since, i started
understanding wine from this end (server code first)

On Tue, 2007-03-06 at 16:25 +0800, Dmitry Timoshkov wrote:
> "Srivatsa Kanchi, R"  wrote:
> > There is nothing wrong with the exiting one; But there is a fixme saying
> > 'should be using getopt', so i did it.
>
> That FIXME tells 'probably'. I'd argue that using getopt in wineserver is
> an overkill since its command line syntax is very simple.
> > and regarding coding style,  they are mentioned in the developer's guide
> > and i tried to follow it
>
> Coding style mentioned in the developer's guide is related to the *new* code,
> not an existing one.