Re: wine/dlls/ntdll critsection.c

[Mike Hearn]

On Mon, 16 Jun 2003 14:36:22 -0500, Sir Alexandre Julliard scribed thus:
> Log message:
>    Mike Hearn 
>    Add the ID of the blocking thread to the error message.

Hi Alexandre,

I'm wondering what the best way to try and make Wines output less scary
is, as the MESSAGE() parts of this patch were not merged. Was the message
not phrased right, or do you think that the console output is an
inappropriate place to put such things?

Alternatively, as Lionel pointed out, it may be that people think they are
not necessary, as the only people who can do anything about it will
understand the message anyway.

thanks -mike

wine/dlls/ntdll critsection.c

[Alexandre Julliard]

Mike Hearn  writes:
> I'm wondering what the best way to try and make Wines output less scary
> is, as the MESSAGE() parts of this patch were not merged. Was the message
> not phrased right, or do you think that the console output is an
> inappropriate place to put such things?

This kind of stuff should go in the documentation, not in the code.

wine/dlls/ntdll critsection.c

[Mike Hearn]

> This kind of stuff should go in the documentation, not in the code.

You mean the documentation that users never seem to read? Of course this
way still sucks as people who launch from the menus never see it :(