Re: PATCH: Convert HMIDI to void*

[Eric Pouech]

Michael Stefaniuc a écrit :
> Hello,
>
> am I right that HMIDI and HMIDIIN, HMIDIOUT shouldn't be
> interchangeable? Would save some conversions.

yes & no
HMIDIIN cannot be used for a HMIDIOUT (anyway, this will be checked
internally by our mmsys implementation: all HMIDI???? handles are stored
in the same table, and we never rely on the HMIDI??? handle type but on
the actual object type)
however, HMIDI can be used for a HMIDIIN (or HMIDIOUT or HMIDISTRM)
handle (see midiConnect for example)

it's true that midimap dll should use HMIDIOUT instead of HMIDI in its
internal data structure
A+

PATCH: Convert HMIDI to void*

[Michael Stefaniuc]

On Wed, Jul 31, 2002 at 10:11:51PM +0200, Eric Pouech wrote:
> Michael Stefaniuc a écrit :
> > am I right that HMIDI and HMIDIIN, HMIDIOUT shouldn't be
> > interchangeable? Would save some conversions.
>
> yes & no
> HMIDIIN cannot be used for a HMIDIOUT (anyway, this will be checked
> internally by our mmsys implementation: all HMIDI???? handles are stored
> in the same table, and we never rely on the HMIDI??? handle type but on
> the actual object type)
> however, HMIDI can be used for a HMIDIIN (or HMIDIOUT or HMIDISTRM)
> handle (see midiConnect for example)

I expressed myself wrong, with interchangable i meant having
typedef HMIDI HMIDIIN
typedef HMIDI HMIDIOUT
typedef HMIDI HMIDISTRM
in include/mmsystem.h instead of
DECLARE_HANDLE(HMIDIIN);
DECLARE_HANDLE(HMIDIOUT);
DECLARE_HANDLE(HMIDISTRM);

I've suspected what you have described from reading the code (but it's
always good to get confirmation).
> it's true that midimap dll should use HMIDIOUT instead of HMIDI in its
> internal data structure

Do you want me to change that?

bye
    michael

PATCH: Convert HMIDI to void*

[Francois Gouget]

On Wed, 31 Jul 2002, Michael Stefaniuc wrote:
[...]
> I expressed myself wrong, with interchangable i meant having
> typedef HMIDI HMIDIIN
> typedef HMIDI HMIDIOUT
> typedef HMIDI HMIDISTRM
> in include/mmsystem.h instead of
> DECLARE_HANDLE(HMIDIIN);
> DECLARE_HANDLE(HMIDIOUT);
> DECLARE_HANDLE(HMIDISTRM);

I just checked and the windows headers declare the HMIDI* handles using
the DECLARE_HANDLE macro. So that's the way we should do it too.

--
Francois Gouget         [e-mail]        http://fgouget.free.fr/
      Any sufficiently advanced bug is indistinguishable from a feature.
                            -- from some indian guy

PATCH: Convert HMIDI to void*

[Michael Stefaniuc]

On Wed, Jul 31, 2002 at 02:25:08PM -0700, Francois Gouget wrote:
> On Wed, 31 Jul 2002, Michael Stefaniuc wrote:
> [...]
> > I expressed myself wrong, with interchangable i meant having
> > typedef HMIDI HMIDIIN
> > typedef HMIDI HMIDIOUT
> > typedef HMIDI HMIDISTRM
> > in include/mmsystem.h instead of
> > DECLARE_HANDLE(HMIDIIN);
> > DECLARE_HANDLE(HMIDIOUT);
> > DECLARE_HANDLE(HMIDISTRM);
>
> I just checked and the windows headers declare the HMIDI* handles using
> the DECLARE_HANDLE macro. So that's the way we should do it too.

That means my patch is valid and can be applied.

Could you please verify that HWAVE HWAVEIN HWAVEOUT HMIXER HMIXEROBJ are
also declared with the DECLARE_HANDLE macro? I don't have the windows
headers.

thanks
bye
    michael

PATCH: Convert HMIDI to void*

[Francois Gouget]

On Wed, 31 Jul 2002, Michael Stefaniuc wrote:
[...]
> Could you please verify that HWAVE HWAVEIN HWAVEOUT HMIXER HMIXEROBJ are
> also declared with the DECLARE_HANDLE macro? I don't have the windows
> headers.

Yep. They are declared using DECLARE_HANDLE too.

--
Francois Gouget         [e-mail]        http://fgouget.free.fr/
In theory, theory and practice are the same, but in practice they're different.