Re: [3/5] comctl32/dpa: Implement DPA_SaveStream() with tests

[Vitaliy Margolen]

Nikolay Sivov wrote:
> Changelog:
>     - Implement DPA_SaveStream() with tests
> - streamData.dwSize  = curr_pos.QuadPart - initial_pos.QuadPart;
> - streamData.dwData2 = 1;
> - streamData.dwItems = streamInfo.iPos;// + 1;

c++ comment.
> +#if 0
> - /* crashes on XP */
> - hRes = pDPA_SaveStream(NULL, CB_Save, pStm, NULL);
> - expect(E_INVALIDARG, hRes);
> -
> - hRes = pDPA_SaveStream(dpa, CB_Save, NULL, NULL);
> - expect(E_INVALIDARG, hRes);
>
> +#endif

Don't use #if 0 / #endif in tests. Use if (0){} instead. This will guarantee
that code will still compile.

Vitaliy.

[3/5] comctl32/dpa: Implement DPA_SaveStream() with tests

[Nikolay Sivov]

Vitaliy Margolen wrote:
> Nikolay Sivov wrote:
> > Changelog:
> >     - Implement DPA_SaveStream() with tests
> > - streamData.dwSize  = curr_pos.QuadPart - initial_pos.QuadPart;
> > - streamData.dwData2 = 1;
> > - streamData.dwItems = streamInfo.iPos;// + 1;
>
> c++ comment.
> > +#if 0
> > - /* crashes on XP */
> > - hRes = pDPA_SaveStream(NULL, CB_Save, pStm, NULL);
> > - expect(E_INVALIDARG, hRes);
> > -
> > - hRes = pDPA_SaveStream(dpa, CB_Save, NULL, NULL);
> > - expect(E_INVALIDARG, hRes);
> >
> > +#endif
>
> Don't use #if 0 / #endif in tests. Use if (0){} instead. This will guarantee
> that code will still compile.
>
> Vitaliy.

Thanks.