Re: d3dx9: Implement D3DXDeclaratorFromFVF.

[Henri Verbeet]

On 20 August 2010 21:16, Misha Koshelev  wrote:
> Thank you for your helpful feedback on my tests.
>
> This is based mostly on dlls/d3d9/vertexdeclaration.c with some
> changes specific to D3DXDeclaratorFromFVF.
>
> Again, if there are any suggested changes please let me know.

As you already mentioned, this is pretty much another copy/paste
implementation, including e.g. the useless macros and typedef.

Re : d3dx9: Implement D3DXDeclaratorFromFVF.

[paulo lesgaz]

I already sent such a patch. Julliard did not like the gazillions of conditions 
if.... then.
I  never found a way to avoid them.
The offset can be computed thanks to the function  D3DXGetDeclVertexSize

A+

David

________________________________
De : Henri Verbeet 
À : [e-mail]
Envoyé le : Lun 23 août 2010, 12h 03min 16s
Objet : Re: d3dx9: Implement D3DXDeclaratorFromFVF.

On 20 August 2010 21:16, Misha Koshelev  wrote:
> Thank you for your helpful feedback on my tests.
>
> This is based mostly on dlls/d3d9/vertexdeclaration.c with some
> changes specific to D3DXDeclaratorFromFVF.
>
> Again, if there are any suggested changes please let me know.

As you already mentioned, this is pretty much another copy/paste
implementation, including e.g. the useless macros and typedef.

Re : d3dx9: Implement D3DXDeclaratorFromFVF.

[Henri Verbeet]

On 23 August 2010 13:49, paulo lesgaz  wrote:
> I already sent such a patch. Julliard did not like the gazillions of
> conditions if.... then.
> I  never found a way to avoid them.
> The offset can be computed thanks to the function  D3DXGetDeclVertexSize

You know, just give the attached patches a try. Untested, of course.

Re : Re : d3dx9: Implement D3DXDeclaratorFromFVF.

[paulo lesgaz]

Both patches work very well (they passed the todo_wine tests)
But, I think that  the second one does not answer to Julliard 's complain about 
tons of if...then
Or maybe there is no way to simplify the patch

David

________________________________
De : Henri Verbeet 
À : paulo lesgaz 
Cc : [e-mail]
Envoyé le : Lun 23 août 2010, 14h 01min 01s
Objet : Re: Re : d3dx9: Implement D3DXDeclaratorFromFVF.

On 23 August 2010 13:49, paulo lesgaz  wrote:
> I already sent such a patch. Julliard did not like the gazillions of
> conditions if.... then.
> I  never found a way to avoid them.
> The offset can be computed thanks to the function  D3DXGetDeclVertexSize

You know, just give the attached patches a try. Untested, of course.

Re : Re : d3dx9: Implement D3DXDeclaratorFromFVF.

[Henri Verbeet]

On 23 August 2010 19:02, paulo lesgaz  wrote:
> Both patches work very well (they passed the todo_wine tests)
> But, I think that  the second one does not answer to Julliard 's complain
> about tons of if...then

I'm not sure I remember reading that specific comment. I know there
was one about the unnecessary BOOLs though.