Am Samstag, 24. Mai 2008 10:33:42 schrieb H. Verbeet:
The color_match() function which this test introduces should be used for the other visual tests that require an approximate match as well, but doing this is outside the scope of this patch.
Dan recently added color_near() for this purpose. Is there any difference between the functions(I see that yours passes the hardcoded slop as a parameter). Do you have any preference towards any implementation? I'm inclined to use yours because of the additional parameter and the better checking with abs()
2008/5/24 Stefan Dösinger stefan@codeweavers.com:
Am Samstag, 24. Mai 2008 10:33:42 schrieb H. Verbeet:
The color_match() function which this test introduces should be used for the other visual tests that require an approximate match as well, but doing this is outside the scope of this patch.
Dan recently added color_near() for this purpose. Is there any difference between the functions(I see that yours passes the hardcoded slop as a parameter). Do you have any preference towards any implementation? I'm inclined to use yours because of the additional parameter and the better checking with abs()
I wrote this test some time ago already, but I do think having the slop as parameter is useful, since the acceptable range of values pretty much depends on the specific test. Another difference is that I check the alpha channel as well, although in practice that doesn't matter here.
-
H. Verbeet -
Stefan Dösinger