Re: [patch]: include : Add missing API to direct-x 9's shader header

[Dmitry Timoshkov]

Kai Tietz  wrote:
> -DEFINE_GUID(IID_ID3DXConstantTable, 0x9dca3190, 0x38b9, 0x4fc3, 0x92,
> 0xe3, 0x39, 0xc6, 0xdd, 0xfb, 0x35, 0x8b);
> +DEFINE_GUID(IID_ID3DXConstantTable, 0xab3c758f, 0x93e, 0x4356, 0xb7,
> 0x62, 0x4d, 0xb1, 0x8f, 0x1b, 0x3a, 0x1);

A quick google search seems to contradict this change. Where does this
come from? Also all of this looks like a plain copy/paste from MS headers,
you can't do that.

[patch]: include : Add missing API to direct-x 9's shader header

[Henri Verbeet]

On 21 January 2014 17:23, Dmitry Timoshkov  wrote:
> Kai Tietz  wrote:
> > -DEFINE_GUID(IID_ID3DXConstantTable, 0x9dca3190, 0x38b9, 0x4fc3, 0x92,
> > 0xe3, 0x39, 0xc6, 0xdd, 0xfb, 0x35, 0x8b);
> > +DEFINE_GUID(IID_ID3DXConstantTable, 0xab3c758f, 0x93e, 0x4356, 0xb7,
> > 0x62, 0x4d, 0xb1, 0x8f, 0x1b, 0x3a, 0x1);
>
> A quick google search seems to contradict this change. Where does this
> come from?

IIRC some interfaces changed GUIDs while keeping the same name between
d3dx9 versions. The changed GUID matches the SDK headers for version
43. It seems likely 43 will be the last version of d3dx9, so we may
want to match that, but we'd have to change e.g. the D3DX_SDK_VERSION
define as well in that case.

[patch]: include : Add missing API to direct-x 9's shader header

[Kai Tietz]

Hi,

2014/1/21 Dmitry Timoshkov :
> Kai Tietz  wrote:
> > -DEFINE_GUID(IID_ID3DXConstantTable, 0x9dca3190, 0x38b9, 0x4fc3, 0x92,
> > 0xe3, 0x39, 0xc6, 0xdd, 0xfb, 0x35, 0x8b);
> > +DEFINE_GUID(IID_ID3DXConstantTable, 0xab3c758f, 0x93e, 0x4356, 0xb7,
> > 0x62, 0x4d, 0xb1, 0x8f, 0x1b, 0x3a, 0x1);
>
> A quick google search seems to contradict this change. Where does this
> come from?

You should learn to use Google more proper.  As then you would find
that IID_ID3DXConstantTable is in Wine indeed wrong.  At least for
version 43. I used as reference the documentation to be found at
http://www-personal.umich.edu/~bazald/l/api/d3dx9shader_8h.html .
> Also all of this looks like a plain copy/paste from MS headers,
> you can't do that.

This allegation is not true.  I don't copy paste.
> --
> Dmitry.