Re: [PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

[Hans Leidekker]

On Wed, 2013-08-28 at 12:21 +0200, Ralf Habacker wrote:
> diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec
> index 36ba13f..1eed5ae 100644
> --- a/dlls/iphlpapi/iphlpapi.spec
> +++ b/dlls/iphlpapi/iphlpapi.spec
> @@ -6,6 +6,7 @@
>  @ stdcall AllocateAndGetIpForwardTableFromStack( ptr long long long )
>  @ stdcall AllocateAndGetIpNetTableFromStack( ptr long long long )
>  @ stdcall AllocateAndGetTcpTableFromStack( ptr long long long )
> +@ stdcall AllocateAndGetTcpExTableFromStack( ptr long long long long )

AllocateAndGetTcpExTableFromStack sorts before AllocateAndGetTcpTableFromStack.
> diff --git a/dlls/iphlpapi/ipstats.h b/dlls/iphlpapi/ipstats.h
> index bf5bb92..efdb1cc 100644
> --- a/dlls/iphlpapi/ipstats.h
> +++ b/dlls/iphlpapi/ipstats.h
> @@ -33,6 +33,7 @@
>  DWORD getInterfaceStatsByName(const char *name, PMIB_IFROW entry) DECLSPEC_HIDDEN;
>
> DWORD WINAPI AllocateAndGetUdpTableFromStack(PMIB_UDPTABLE *ppUdpTable, BOOL bOrder, HANDLE heap, DWORD flags) DECLSPEC_HIDDEN;
> +DWORD WINAPI AllocateAndGetTcpExTableFromStack(PVOID *ppTcpTable, BOOL bOrder, HANDLE heap, DWORD flags, DWORD family) DECLSPEC_HIDDEN;

Again, you don't need this part.

[PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

[Ralf Habacker]

On 28.08.2013 12:54, Hans Leidekker wrote:
> On Wed, 2013-08-28 at 12:21 +0200, Ralf Habacker wrote:
> > diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec
> > index 36ba13f..1eed5ae 100644
> > --- a/dlls/iphlpapi/iphlpapi.spec
> > +++ b/dlls/iphlpapi/iphlpapi.spec
> > @@ -6,6 +6,7 @@
> >   @ stdcall AllocateAndGetIpForwardTableFromStack( ptr long long long )
> >   @ stdcall AllocateAndGetIpNetTableFromStack( ptr long long long )
> >   @ stdcall AllocateAndGetTcpTableFromStack( ptr long long long )
> > +@ stdcall AllocateAndGetTcpExTableFromStack( ptr long long long long )
>
> AllocateAndGetTcpExTableFromStack sorts before AllocateAndGetTcpTableFromStack.

sorted the entry below - sorry, updated patch
> > diff --git a/dlls/iphlpapi/ipstats.h b/dlls/iphlpapi/ipstats.h
> > index bf5bb92..efdb1cc 100644
> > --- a/dlls/iphlpapi/ipstats.h
> > +++ b/dlls/iphlpapi/ipstats.h
> > @@ -33,6 +33,7 @@
> >   DWORD getInterfaceStatsByName(const char *name, PMIB_IFROW entry) DECLSPEC_HIDDEN;
> >
> > DWORD WINAPI AllocateAndGetUdpTableFromStack(PMIB_UDPTABLE *ppUdpTable, BOOL bOrder, HANDLE heap, DWORD flags) DECLSPEC_HIDDEN;
> > +DWORD WINAPI AllocateAndGetTcpExTableFromStack(PVOID *ppTcpTable, BOOL bOrder, HANDLE heap, DWORD flags, DWORD family) DECLSPEC_HIDDEN;
>
> Again, you don't need this part.

This is because it is used nowhere else yet ?

Ralf
>

[PATCH] iphlpapi: Add AllocateAndGetTcpExTableFromStack().

[Hans Leidekker]

On Wed, 2013-08-28 at 14:49 +0200, Ralf Habacker wrote:
> > > diff --git a/dlls/iphlpapi/ipstats.h b/dlls/iphlpapi/ipstats.h
> > > index bf5bb92..efdb1cc 100644
> > > --- a/dlls/iphlpapi/ipstats.h
> > > +++ b/dlls/iphlpapi/ipstats.h
> > > @@ -33,6 +33,7 @@
> > >   DWORD getInterfaceStatsByName(const char *name, PMIB_IFROW entry) DECLSPEC_HIDDEN;
> > >
> > > DWORD WINAPI AllocateAndGetUdpTableFromStack(PMIB_UDPTABLE *ppUdpTable, BOOL bOrder, HANDLE heap, DWORD flags) DECLSPEC_HIDDEN;
> > > +DWORD WINAPI AllocateAndGetTcpExTableFromStack(PVOID *ppTcpTable, BOOL bOrder, HANDLE heap, DWORD flags, DWORD family) DECLSPEC_HIDDEN;
> >
> > Again, you don't need this part.
>
> This is because it is used nowhere else yet ?

Yes, it's not used and likely won't be because build_tcp_table can be used instead.