OK, seems there was a small bug in the last patch that could cause crashes, plus I'd forgotten to include wine.inf.in. I'm pretty sure this one should be fine now, at least. Sorry for all the messages. ;-)
Just wondering if anybody has any feedback on these, as I notice they've not been accepted into the last couple of rounds of commits. If there's anything glaringly wrong with it that I haven't spotted, or another reason why they've not made it into the codebase yet, please do let me know. :-)
Thanks,
OK, seems there was a small bug in the last patch that could cause crashes, plus I'd forgotten to include wine.inf.in. I'm pretty sure this one should be fine now, at least. Sorry for all the messages. ;-)
Just wondering if anybody has any feedback on these, as I notice they've not been accepted into the last couple of rounds of commits. If there's anything glaringly wrong with it that I haven't spotted, or another reason why they've not made it into the codebase yet, please do let me know. :-)
Thanks,
-- Owen Rudge http://www.owenrudge.net/
Perhaps you could split them into smaller parts?
Alexander N. Sørnes
Perhaps you could split them into smaller parts?
Well, I'm not sure how much smaller I can realistically split them, at least, if the individual parts are to be functional, although I guess the first and second ones (which are the largest) could be split up a little more if that is the reason they weren't accepted.
On 17.07.2008 17:22, Owen Rudge wrote:
Well, I'm not sure how much smaller I can realistically split them, at least, if the individual parts are to be functional, although I guess the first and second ones (which are the largest) could be split up a little more if that is the reason they weren't accepted.
The larger a chunk is the harder a review is. I think a patch doesn't necessarily have to have a "sensibly" functional result. E.g. you could start off with a very skeleton control panel, maybe icons which don't do anything. Sure, it's not very functional, but it is very easy to review. Likewise, the next step could add a do-nothing dialog ... and so on.
-f.r.
The larger a chunk is the harder a review is. I think a patch doesn't necessarily have to have a "sensibly" functional result. E.g. you could start off with a very skeleton control panel, maybe icons which don't do anything. Sure, it's not very functional, but it is very easy to review. Likewise, the next step could add a do-nothing dialog ... and so on.
Yes, this is more or less what I was planning to do now. I'll have a rumble around and see what I can come up with.
-
Alexander Nicolaysen Sørnes -
Frank Richter -
Owen Rudge