Regression in Lotus Notes R5 between wine-0.9.27 and wine-0.9.28

[Pedro Araujo Chaves Jr.]

Hi all,

There's been a regression in printing in Lotus Notes R5 somewhere between
wine-0.9.27 and wine-0.9.28: it seems that the presence of an inline picture
(in this case, a logo) in the mail stationery prevents all text (including
header text) from being printed.

Odd as it may seem, my regression testing pointed commit
21635133fb271405fefd6bce3078cf971e84c426 as the cause. I positioned my tree
just before it, and the mail printed okay; I applied it, the mail came out
blank again.

As I still couldn't see any direct relation between the said commit and this
issue, I'm posting here in the hope someone would be able to figure out
what's going on. If that's the case, then, I'll file a bug report and upload
a database containing a message with one of these problematic stationeries.

Regards,

[Alexandre Julliard]

"Pedro Araujo Chaves Jr."  writes:
> Odd as it may seem, my regression testing pointed commit
> 21635133fb271405fefd6bce3078cf971e84c426 as the cause. I positioned my tree
> just before it, and the mail printed okay; I applied it, the mail came out
> blank again.

Try this patch:

diff --git a/dlls/wineps.drv/init.c b/dlls/wineps.drv/init.c
index bd9c16c..23b6cfd 100644
--- a/dlls/wineps.drv/init.c
+++ b/dlls/wineps.drv/init.c
@@ -426,8 +426,10 @@ INT PSDRV_GetDeviceCaps( PSDRV_PDEVICE *physDev, INT cap )
         return MulDiv(physDev->vertSize, 100,
    	      physDev->Devmode->dmPublic.dmScale);
     case HORZRES:
+    case DESKTOPHORZRES:
         return physDev->horzRes;
     case VERTRES:
+    case DESKTOPVERTRES:
         return physDev->vertRes;
     case BITSPIXEL:
         return (physDev->pi->ppd->ColorDevice != CD_False) ? 8 : 1;
@@ -508,8 +510,6 @@ INT PSDRV_GetDeviceCaps( PSDRV_PDEVICE *physDev, INT cap )
     case SCALINGFACTORX:
     case SCALINGFACTORY:
     case VREFRESH:
-    case DESKTOPVERTRES:
-    case DESKTOPHORZRES:
     case BLTALIGNMENT:
         return 0;
     default:

[Pedro Araujo Chaves Jr.]

On 3/6/07, Alexandre Julliard  wrote:
> Try this patch:
>
> diff --git a/dlls/wineps.drv/init.c b/dlls/wineps.drv/init.c
> index bd9c16c..23b6cfd 100644
> --- a/dlls/wineps.drv/init.c
> +++ b/dlls/wineps.drv/init.c

Yeah, that dit it; thanks!

Can I expect to see this in 0.9.33, then?

Cheers,
- Pedro.

[Alexandre Julliard]

"Pedro Araujo Chaves Jr."  writes:
> On 3/6/07, Alexandre Julliard  wrote:
> > Try this patch:
> >
> > diff --git a/dlls/wineps.drv/init.c b/dlls/wineps.drv/init.c
> > index bd9c16c..23b6cfd 100644
> > --- a/dlls/wineps.drv/init.c
> > +++ b/dlls/wineps.drv/init.c
>
> Yeah, that dit it; thanks!
>
> Can I expect to see this in 0.9.33, then?

Yes, I'll put it in.