On Apr 3, 2005 10:12 PM, Kees Cook kees@outflux.net wrote:
To store the triplets, these functions use the registry:
Registry Layout: HKEY_CURRENT_USER\Software\Wine\Crypt\ProtectData\Map[index] Cipher: HEX string Entropy: HEX string DataDescription: WCHAR Plain: HEX string
I'll have to be honest that I haven't looked over the code yet, but I do have a concern. Do these values have to be stored under Software\Wine? That location is for wine-specific configuration options and not api use, unless I'm mistaken. Do we know if this data is stored in the registry in windows, and if so where is it stored? (because I know it's not Software\Wine ;-)
On Sun, Apr 03, 2005 at 11:04:53PM -0500, James Hawkins wrote:
On Apr 3, 2005 10:12 PM, Kees Cook kees@outflux.net wrote:
To store the triplets, these functions use the registry:
Registry Layout: HKEY_CURRENT_USER\Software\Wine\Crypt\ProtectData\Map[index] Cipher: HEX string Entropy: HEX string DataDescription: WCHAR Plain: HEX string
I'll have to be honest that I haven't looked over the code yet, but I do have a concern. Do these values have to be stored under Software\Wine? That location is for wine-specific configuration options and not api use, unless I'm mistaken. Do we know if this data is stored in the registry in windows, and if so where is it stored? (because I know it's not Software\Wine ;-)
Windows doesn't store the results anywhere: it's just a symmetric crypto function. Since we don't know the function, we have to store the original data somewhere so we can return it later. Since this is entirely a Wine-only implementation of the "encryption", I wanted to put it somewhere in the registry totally separate from all the other keys. Within the Wine tree seemed like the best place.
On Apr 3, 2005 11:44 PM, Kees Cook kees@outflux.net wrote:
Windows doesn't store the results anywhere: it's just a symmetric crypto function. Since we don't know the function, we have to store the original data somewhere so we can return it later. Since this is entirely a Wine-only implementation of the "encryption", I wanted to put it somewhere in the registry totally separate from all the other keys. Within the Wine tree seemed like the best place.
I understand your logic behind the decision, but while it is true that the details of wine's implementation of the 'encryption' is different from that of windows', these details aren't a trait of wine itself. Wine is an implementation of the Windows api, but the details of how we do it should be encapsulated. What I'm getting at is that just because this implementation is wine-specific doesn't mean some of the implementation data should go in Software\Wine. Software\Wine is where the configurations of the wine program itself, not its implementation, are contained. See what I mean? btw it's great that you wrote this code and submitted it. Sending the code in is the big first step. I just think we should get a community opinion on this matter (ya never know, everyone may disagree with me!). Keep up the good coding.
On Sun, Apr 03, 2005 at 11:56:34PM -0500, James Hawkins wrote:
we do it should be encapsulated. What I'm getting at is that just because this implementation is wine-specific doesn't mean some of the implementation data should go in Software\Wine. Software\Wine is where the configurations of the wine program itself, not its implementation, are contained. See what I mean? btw it's great that
Sure, that's fine by me. I wasn't really sure where to put it, but it's easy to change; it's just a path at the top of the file. In looking around at other examples, it seemed the most sensible. Is there a "normal" implementation-data-storage area for Wine? I just wanted to avoid clashing with any other registry items.
I'm open to any suggestions. :)
you wrote this code and submitted it. Sending the code in is the big first step. I just think we should get a community opinion on this matter (ya never know, everyone may disagree with me!). Keep up the good coding.
Thanks!
On Apr 4, 2005 12:00 AM, Kees Cook kees@outflux.net wrote:
Sure, that's fine by me. I wasn't really sure where to put it, but it's easy to change; it's just a path at the top of the file. In looking around at other examples, it seemed the most sensible. Is there a "normal" implementation-data-storage area for Wine? I just wanted to avoid clashing with any other registry items.
I'm open to any suggestions. :)
I wish I could give a definitive answer, but I think waiting for the weekend to be over so more of the developers will be able to give input is a good idea. It could even turn out that the best place to put it actually is Software\Wine, so we'll see what happens.
-
James Hawkins -
Kees Cook