[RFC] A Light Blue theme.

[Zhiyi Zhang]

Hi all,

I've been working on theming support for Wine for awhile now. Part of the work is to create a .msstyles file so
that UI controls can look better instead of that Win95 look. Now I think it has reached a point where it's good
enough for you to try it.

The Light Blue theme contains two visual styles. One is Classic Blue and the other is Blue. Classic Blue is a visual
style that changes only the system colors and doesn't contain any bitmaps for UI controls. So it still uses the
unthemed rendering code path. Blue is a visual style that contains bitmaps for UI controls so it no longer has that
Win95-ish look. To install the theme, download attached light.zip and install light.msstyles via winecfg. The
patches are on top of Wine 6.10 aadcff4. More in development theme work is at https://github.com/zzhiyi/wine/commits/dev,
For example, hooking nonclient scrollbar in user32 to uxtheme.

Theming support for Wine still need more fixes. So even with this theme file, some controls may still render
poorly/incorrectly. Below is a non-exhaustive list of the theming problems I know of. Some of them are HiDPI issues,
some are because of themed rendering is not implemented. Let me know if you encounter any other issues or have
suggestions, specifically, regarding the theme file light.msstyles.

Enjoy!

Zhiyi

Known theme issues:
1. Themed explorer support is not implemented, so startmenu, taskbar, titlbar are not themed.
2. Nonclient area theming support is not implemented.
3. Taskdialog theming support is not implemented
4. Unthemed system metrics are not restored after disabling theme, e.g., IconTitleFont after disabling theme
5. Comctl32 v6 should be loaded in some cases even if there is no comctl32 v6 manifest in applications.
6. Winecfg should close current theme before copying a new theme because the name may be the same.
7. When using comctl32 v5, scrollbars and dialogs should not be themed.
8. Trackbar has wrong background color when themed.
9. In Winecfg desktop integration tab, the postion of size updown buttons change after theme changes.
10. Spy++ toolbar icons has dots and black artifacts
11. Changing theme in winecfg doesn't affect windows in other processes in runtime
12. Application title bar is inactive on launch when not using window manager decoration
13. Combox button doesn't stay pressed after clicking and moving mouse the the dropdown menu
14. Select toolbar in controlspy, resize control spy to a larger size. scrollbar doesn't get repaint
15. Treeview in controlspy, expanded Planets still has old background
16. Trackbar adding style TBS_BOTH doesn't repaint on Wine, repaints on Windows
17. Stutter when moving the thumb of trackbar, even if no theme is active
18. EDIT_WM_Paint() should use themed paint.
19. Buttons and edits in dialogs  are not themed
20. Tooltip ballon shape is incorrect
21. Theme may not be updated on wineprefix upgrade.

Known HiDPI issues:
1. Status Bar in control spy v6 when HiDPI is on, the purple triangle doesn't get enough space
2. Syslink no address is showed, DPI 192
3. Command links no text on HiDPI
4. In file selection dialog folder name size is not the same when showed in preview and in selected mode

[Zhiyi Zhang]

Some gmail users report that they didn't receive this email. It's probably because some virus scanners mistakenly treat light.msstyles
in the zip as a virus or something. So I put the zip at https://zzhiyi.github.io/light.zip as well. Hopefully this email will get through.

On 6/8/21 11:35 PM, Zhiyi Zhang wrote:
> Hi all,
>
> I've been working on theming support for Wine for awhile now. Part of the work is to create a .msstyles file so
> that UI controls can look better instead of that Win95 look. Now I think it has reached a point where it's good
> enough for you to try it.
>
> The Light Blue theme contains two visual styles. One is Classic Blue and the other is Blue. Classic Blue is a visual
> style that changes only the system colors and doesn't contain any bitmaps for UI controls. So it still uses the
> unthemed rendering code path. Blue is a visual style that contains bitmaps for UI controls so it no longer has that
> Win95-ish look. To install the theme, download attached light.zip and install light.msstyles via winecfg. The
> patches are on top of Wine 6.10 aadcff4. More in development theme work is at https://github.com/zzhiyi/wine/commits/dev,
> For example, hooking nonclient scrollbar in user32 to uxtheme.
>
> Theming support for Wine still need more fixes. So even with this theme file, some controls may still render
> poorly/incorrectly. Below is a non-exhaustive list of the theming problems I know of. Some of them are HiDPI issues,
> some are because of themed rendering is not implemented. Let me know if you encounter any other issues or have
> suggestions, specifically, regarding the theme file light.msstyles.
>
> Enjoy!
>
> Zhiyi
>
> Known theme issues:
> - Themed explorer support is not implemented, so startmenu, taskbar, titlbar are not themed.
> - Nonclient area theming support is not implemented.
> - Taskdialog theming support is not implemented
> - Unthemed system metrics are not restored after disabling theme, e.g., IconTitleFont after disabling theme
> - Comctl32 v6 should be loaded in some cases even if there is no comctl32 v6 manifest in applications.
> - Winecfg should close current theme before copying a new theme because the name may be the same.
> - When using comctl32 v5, scrollbars and dialogs should not be themed.
> - Trackbar has wrong background color when themed.
> - In Winecfg desktop integration tab, the postion of size updown buttons change after theme changes.
> - Spy++ toolbar icons has dots and black artifacts
> - Changing theme in winecfg doesn't affect windows in other processes in runtime
> - Application title bar is inactive on launch when not using window manager decoration
> - Combox button doesn't stay pressed after clicking and moving mouse the the dropdown menu
> - Select toolbar in controlspy, resize control spy to a larger size. scrollbar doesn't get repaint
> - Treeview in controlspy, expanded Planets still has old background
> - Trackbar adding style TBS_BOTH doesn't repaint on Wine, repaints on Windows
> - Stutter when moving the thumb of trackbar, even if no theme is active
> - EDIT_WM_Paint() should use themed paint.
> - Buttons and edits in dialogs  are not themed
> - Tooltip ballon shape is incorrect
> - Theme may not be updated on wineprefix upgrade.
>
> Known HiDPI issues:
> - Status Bar in control spy v6 when HiDPI is on, the purple triangle doesn't get enough space
> - Syslink no address is showed, DPI 192
> - Command links no text on HiDPI
> - In file selection dialog folder name size is not the same when showed in preview and in selected mode

[Joshua Ashton]

Hi Zhiyi,

I'm using GMail and recieved this email now. :-)

Would you be able to provide some pictures?

I made a Wine theme a little while ago, but it was not MSStyles, rather 
just some code changes for the regular path and I am curious as to what 
yours looks like.

- Joshie 🐸✨

On 6/9/21 4:38 PM, Zhiyi Zhang wrote:
> Some gmail users report that they didn't receive this email. It's probably because some virus scanners mistakenly treat light.msstyles
> in the zip as a virus or something. So I put the zip at https://zzhiyi.github.io/light.zip as well. Hopefully this email will get through.
>
> On 6/8/21 11:35 PM, Zhiyi Zhang wrote:
> > Hi all,
> >
> > I've been working on theming support for Wine for awhile now. Part of the work is to create a .msstyles file so
> > that UI controls can look better instead of that Win95 look. Now I think it has reached a point where it's good
> > enough for you to try it.
> >
> > The Light Blue theme contains two visual styles. One is Classic Blue and the other is Blue. Classic Blue is a visual
> > style that changes only the system colors and doesn't contain any bitmaps for UI controls. So it still uses the
> > unthemed rendering code path. Blue is a visual style that contains bitmaps for UI controls so it no longer has that
> > Win95-ish look. To install the theme, download attached light.zip and install light.msstyles via winecfg. The
> > patches are on top of Wine 6.10 aadcff4. More in development theme work is at https://github.com/zzhiyi/wine/commits/dev,
> > For example, hooking nonclient scrollbar in user32 to uxtheme.
> >
> > Theming support for Wine still need more fixes. So even with this theme file, some controls may still render
> > poorly/incorrectly. Below is a non-exhaustive list of the theming problems I know of. Some of them are HiDPI issues,
> > some are because of themed rendering is not implemented. Let me know if you encounter any other issues or have
> > suggestions, specifically, regarding the theme file light.msstyles.
> >
> > Enjoy!
> >
> > Zhiyi
> >
> > Known theme issues:
> > - Themed explorer support is not implemented, so startmenu, taskbar, titlbar are not themed.
> > - Nonclient area theming support is not implemented.
> > - Taskdialog theming support is not implemented
> > - Unthemed system metrics are not restored after disabling theme, e.g., IconTitleFont after disabling theme
> > - Comctl32 v6 should be loaded in some cases even if there is no comctl32 v6 manifest in applications.
> > - Winecfg should close current theme before copying a new theme because the name may be the same.
> > - When using comctl32 v5, scrollbars and dialogs should not be themed.
> > - Trackbar has wrong background color when themed.
> > - In Winecfg desktop integration tab, the postion of size updown buttons change after theme changes.
> > - Spy++ toolbar icons has dots and black artifacts
> > - Changing theme in winecfg doesn't affect windows in other processes in runtime
> > - Application title bar is inactive on launch when not using window manager decoration
> > - Combox button doesn't stay pressed after clicking and moving mouse the the dropdown menu
> > - Select toolbar in controlspy, resize control spy to a larger size. scrollbar doesn't get repaint
> > - Treeview in controlspy, expanded Planets still has old background
> > - Trackbar adding style TBS_BOTH doesn't repaint on Wine, repaints on Windows
> > - Stutter when moving the thumb of trackbar, even if no theme is active
> > - EDIT_WM_Paint() should use themed paint.
> > - Buttons and edits in dialogs  are not themed
> > - Tooltip ballon shape is incorrect
> > - Theme may not be updated on wineprefix upgrade.
> >
> > Known HiDPI issues:
> > - Status Bar in control spy v6 when HiDPI is on, the purple triangle doesn't get enough space
> > - Syslink no address is showed, DPI 192
> > - Command links no text on HiDPI
> > - In file selection dialog folder name size is not the same when showed in preview and in selected mode

[Zhiyi Zhang]

Hi Joshua,

I made a video demo. It's available at https://zzhiyi.github.io/light-theme-demo.webm, as well as https://www.youtube.com/watch?v=9wHYps7dXAU.

Cheers,
Zhiyi

On 6/10/21 1:56 AM, Joshua Ashton wrote:
> Hi Zhiyi,
>
> I'm using GMail and recieved this email now. :-)
>
> Would you be able to provide some pictures?
>
> I made a Wine theme a little while ago, but it was not MSStyles, rather just some code changes for the regular path and I am curious as to what yours looks like.
> - Joshie 🐸✨
>
> On 6/9/21 4:38 PM, Zhiyi Zhang wrote:
> > Some gmail users report that they didn't receive this email. It's probably because some virus scanners mistakenly treat light.msstyles
> > in the zip as a virus or something. So I put the zip at https://zzhiyi.github.io/light.zip as well. Hopefully this email will get through.
> >
> > On 6/8/21 11:35 PM, Zhiyi Zhang wrote:
> > > Hi all,
> > >
> > > I've been working on theming support for Wine for awhile now. Part of the work is to create a .msstyles file so
> > > that UI controls can look better instead of that Win95 look. Now I think it has reached a point where it's good
> > > enough for you to try it.
> > >
> > > The Light Blue theme contains two visual styles. One is Classic Blue and the other is Blue. Classic Blue is a visual
> > > style that changes only the system colors and doesn't contain any bitmaps for UI controls. So it still uses the
> > > unthemed rendering code path. Blue is a visual style that contains bitmaps for UI controls so it no longer has that
> > > Win95-ish look. To install the theme, download attached light.zip and install light.msstyles via winecfg. The
> > > patches are on top of Wine 6.10 aadcff4. More in development theme work is at https://github.com/zzhiyi/wine/commits/dev,
> > > For example, hooking nonclient scrollbar in user32 to uxtheme.
> > >
> > > Theming support for Wine still need more fixes. So even with this theme file, some controls may still render
> > > poorly/incorrectly. Below is a non-exhaustive list of the theming problems I know of. Some of them are HiDPI issues,
> > > some are because of themed rendering is not implemented. Let me know if you encounter any other issues or have
> > > suggestions, specifically, regarding the theme file light.msstyles.
> > >
> > > Enjoy!
> > >
> > > Zhiyi
> > >
> > > Known theme issues:
> > > - Themed explorer support is not implemented, so startmenu, taskbar, titlbar are not themed.
> > > - Nonclient area theming support is not implemented.
> > > - Taskdialog theming support is not implemented
> > > - Unthemed system metrics are not restored after disabling theme, e.g., IconTitleFont after disabling theme
> > > - Comctl32 v6 should be loaded in some cases even if there is no comctl32 v6 manifest in applications.
> > > - Winecfg should close current theme before copying a new theme because the name may be the same.
> > > - When using comctl32 v5, scrollbars and dialogs should not be themed.
> > > - Trackbar has wrong background color when themed.
> > > - In Winecfg desktop integration tab, the postion of size updown buttons change after theme changes.
> > > - Spy++ toolbar icons has dots and black artifacts
> > > - Changing theme in winecfg doesn't affect windows in other processes in runtime
> > > - Application title bar is inactive on launch when not using window manager decoration
> > > - Combox button doesn't stay pressed after clicking and moving mouse the the dropdown menu
> > > - Select toolbar in controlspy, resize control spy to a larger size. scrollbar doesn't get repaint
> > > - Treeview in controlspy, expanded Planets still has old background
> > > - Trackbar adding style TBS_BOTH doesn't repaint on Wine, repaints on Windows
> > > - Stutter when moving the thumb of trackbar, even if no theme is active
> > > - EDIT_WM_Paint() should use themed paint.
> > > - Buttons and edits in dialogs  are not themed
> > > - Tooltip ballon shape is incorrect
> > > - Theme may not be updated on wineprefix upgrade.
> > >
> > > Known HiDPI issues:
> > > - Status Bar in control spy v6 when HiDPI is on, the purple triangle doesn't get enough space
> > > - Syslink no address is showed, DPI 192
> > > - Command links no text on HiDPI
> > > - In file selection dialog folder name size is not the same when showed in preview and in selected mode

[Joshua Ashton]

Looks nice, similar to the theme I made recently (although it wasn't 
msstyles, I just bodged it).

Have you tried making the pseudo-3D-controls flat yet? I did that for 
tabs and other stuff and it ended up looking much more modern.

Hope this gets in, will be nice to not have Windows 98-style controls as 
people's first perception of running Windows apps under Linux.

- Joshie 🐸✨

On 6/10/21 3:49 AM, Zhiyi Zhang wrote:
> Hi Joshua,
>
> I made a video demo. It's available at https://zzhiyi.github.io/light-theme-demo.webm, as well as https://www.youtube.com/watch?v=9wHYps7dXAU.
>
> Cheers,
> Zhiyi
>
> On 6/10/21 1:56 AM, Joshua Ashton wrote:
> > Hi Zhiyi,
> >
> > I'm using GMail and recieved this email now. :-)
> >
> > Would you be able to provide some pictures?
> >
> > I made a Wine theme a little while ago, but it was not MSStyles, rather just some code changes for the regular path and I am curious as to what yours looks like.
> > - Joshie 🐸✨
> >
> > On 6/9/21 4:38 PM, Zhiyi Zhang wrote:
> > > Some gmail users report that they didn't receive this email. It's probably because some virus scanners mistakenly treat light.msstyles
> > > in the zip as a virus or something. So I put the zip at https://zzhiyi.github.io/light.zip as well. Hopefully this email will get through.
> > >
> > > On 6/8/21 11:35 PM, Zhiyi Zhang wrote:
> > > > Hi all,
> > > >
> > > > I've been working on theming support for Wine for awhile now. Part of the work is to create a .msstyles file so
> > > > that UI controls can look better instead of that Win95 look. Now I think it has reached a point where it's good
> > > > enough for you to try it.
> > > >
> > > > The Light Blue theme contains two visual styles. One is Classic Blue and the other is Blue. Classic Blue is a visual
> > > > style that changes only the system colors and doesn't contain any bitmaps for UI controls. So it still uses the
> > > > unthemed rendering code path. Blue is a visual style that contains bitmaps for UI controls so it no longer has that
> > > > Win95-ish look. To install the theme, download attached light.zip and install light.msstyles via winecfg. The
> > > > patches are on top of Wine 6.10 aadcff4. More in development theme work is at https://github.com/zzhiyi/wine/commits/dev,
> > > > For example, hooking nonclient scrollbar in user32 to uxtheme.
> > > >
> > > > Theming support for Wine still need more fixes. So even with this theme file, some controls may still render
> > > > poorly/incorrectly. Below is a non-exhaustive list of the theming problems I know of. Some of them are HiDPI issues,
> > > > some are because of themed rendering is not implemented. Let me know if you encounter any other issues or have
> > > > suggestions, specifically, regarding the theme file light.msstyles.
> > > >
> > > > Enjoy!
> > > >
> > > > Zhiyi
> > > >
> > > > Known theme issues:
> > > > - Themed explorer support is not implemented, so startmenu, taskbar, titlbar are not themed.
> > > > - Nonclient area theming support is not implemented.
> > > > - Taskdialog theming support is not implemented
> > > > - Unthemed system metrics are not restored after disabling theme, e.g., IconTitleFont after disabling theme
> > > > - Comctl32 v6 should be loaded in some cases even if there is no comctl32 v6 manifest in applications.
> > > > - Winecfg should close current theme before copying a new theme because the name may be the same.
> > > > - When using comctl32 v5, scrollbars and dialogs should not be themed.
> > > > - Trackbar has wrong background color when themed.
> > > > - In Winecfg desktop integration tab, the postion of size updown buttons change after theme changes.
> > > > - Spy++ toolbar icons has dots and black artifacts
> > > > - Changing theme in winecfg doesn't affect windows in other processes in runtime
> > > > - Application title bar is inactive on launch when not using window manager decoration
> > > > - Combox button doesn't stay pressed after clicking and moving mouse the the dropdown menu
> > > > - Select toolbar in controlspy, resize control spy to a larger size. scrollbar doesn't get repaint
> > > > - Treeview in controlspy, expanded Planets still has old background
> > > > - Trackbar adding style TBS_BOTH doesn't repaint on Wine, repaints on Windows
> > > > - Stutter when moving the thumb of trackbar, even if no theme is active
> > > > - EDIT_WM_Paint() should use themed paint.
> > > > - Buttons and edits in dialogs  are not themed
> > > > - Tooltip ballon shape is incorrect
> > > > - Theme may not be updated on wineprefix upgrade.
> > > >
> > > > Known HiDPI issues:
> > > > - Status Bar in control spy v6 when HiDPI is on, the purple triangle doesn't get enough space
> > > > - Syslink no address is showed, DPI 192
> > > > - Command links no text on HiDPI
> > > > - In file selection dialog folder name size is not the same when showed in preview and in selected mode

[Rémi Bernon]

On 6/10/21 7:34 AM, Joshua Ashton wrote:
> Looks nice, similar to the theme I made recently (although it wasn't 
> msstyles, I just bodged it).
>
> Have you tried making the pseudo-3D-controls flat yet? I did that for 
> tabs and other stuff and it ended up looking much more modern.
>
> Hope this gets in, will be nice to not have Windows 98-style controls as 
> people's first perception of running Windows apps under Linux.

The "Blue" theme (shown after "Classic Blue") looks pretty flat already, 
and I think it also looks really nice! It's a bit like Windows 10 but 
smoother and more unique with the slightly rounded corners.

[Joshua Ashton]

Yeah it is definitely much more flat but it seemed like there were a 
couple pseudo-3D elements still in the ControlSpy section?
(Maybe they can't be fixed via msstyles, I am not sure).

I also removed the rounding on the tabs, although that's definitely up 
to personal taste and might need more definition to be visible in that 
case, but might be interesting to see it if it is possible.

(Feel free to take or discard my suggestions, not trying to dictate 
anything here, it looks good enough :p)

- Joshie 🐸✨

On 6/10/21 6:47 AM, Rémi Bernon wrote:
> On 6/10/21 7:34 AM, Joshua Ashton wrote:
> > Looks nice, similar to the theme I made recently (although it wasn't 
> > msstyles, I just bodged it).
> >
> > Have you tried making the pseudo-3D-controls flat yet? I did that for 
> > tabs and other stuff and it ended up looking much more modern.
> >
> > Hope this gets in, will be nice to not have Windows 98-style controls 
> > as people's first perception of running Windows apps under Linux.
>
> The "Blue" theme (shown after "Classic Blue") looks pretty flat already, 
> and I think it also looks really nice! It's a bit like Windows 10 but 
> smoother and more unique with the slightly rounded corners.

[Zhiyi Zhang]

On 6/10/21 1:44 PM, Joshua Ashton wrote:
> Yeah it is definitely much more flat but it seemed like there were a couple pseudo-3D elements still in the ControlSpy section?

I am glad you enjoy it. If you mean the WPARAM and LPARAM elements in the send message tab are pseudo-3D,  then yes, those
seems to be not themed. However, it's the same behavior on Windows 10. So I haven't looked much into it.

The "Blue" theme bitmaps are actual all flat. If you look the the SVGs. You'll notice all the icons are made without any special effects.
Part of the reason is that I like it this way. Another part is that I was lazy to add those effects.

As for the rounded corners, I actually tried sharp corners and decided that rounded corners look nicer. The icons are all rounded at 2px
in both x and y when appropriate. And yes, such things are up to personal taste. After this theme gets in and other theming work is done,
we can try all sort of ideas, e.g., sharp corners, different colors, special effects, even a dynamic theme generator that can generate a
similar theme as host environment/qt/gtk/mac.

Thanks,
Zhiyi
> (Maybe they can't be fixed via msstyles, I am not sure).
>
> I also removed the rounding on the tabs, although that's definitely up to personal taste and might need more definition to be visible in that case, but might be interesting to see it if it is possible.
>
> (Feel free to take or discard my suggestions, not trying to dictate anything here, it looks good enough :p)
> - Joshie 🐸✨
>
> On 6/10/21 6:47 AM, Rémi Bernon wrote:
> > On 6/10/21 7:34 AM, Joshua Ashton wrote:
> > > Looks nice, similar to the theme I made recently (although it wasn't msstyles, I just bodged it).
> > >
> > > Have you tried making the pseudo-3D-controls flat yet? I did that for tabs and other stuff and it ended up looking much more modern.
> > >
> > > Hope this gets in, will be nice to not have Windows 98-style controls as people's first perception of running Windows apps under Linux.
> >
> > The "Blue" theme (shown after "Classic Blue") looks pretty flat already, and I think it also looks really nice! It's a bit like Windows 10 but smoother and more unique with the slightly rounded corners.