Re: Minor dlls/mshtml/htmlbody.c simplification

[Jacek Caban]

Hi Gerald,

On 4/21/10 1:45 PM, Gerald Pfeifer wrote:
> ChangeLog:
> Remove variable hres which is not really used from HTMLBodyElement_get_text.
>
> diff --git a/dlls/mshtml/htmlbody.c b/dlls/mshtml/htmlbody.c
> index 5c66e65..c6b202b 100644
> --- a/dlls/mshtml/htmlbody.c
> +++ b/dlls/mshtml/htmlbody.c
> @@ -443,7 +443,6 @@ static HRESULT WINAPI HTMLBodyElement_get_text(IHTMLBodyElement *iface, VARIANT
>       HTMLBodyElement *This = HTMLBODY_THIS(iface);
>       nsAString text;
>       nsresult nsres;
> -
>
> HRESULT hres;
>
> TRACE("(%p)->(%p)\n", This, p);
>
> @@ -454,10 +453,8 @@ static HRESULT WINAPI HTMLBodyElement_get_text(IHTMLBodyElement *iface, VARIANT
>       nsAString_GetData(&text,&color);
>       V_VT(p) = VT_BSTR;
> -
>    hres = nscolor_to_str(color,&V_BSTR(p));
> }else {
>     ERR("GetText failed: %08x\n", nsres);
> -
>    hres = E_FAIL;
> }
>
> nsAString_Finish(&text);

hres should be returned in this case, not removed.

Jacek