On 10/1/06, EA Durbin ead1234@hotmail.com wrote:
Please read up on the patch submission process [1]. Only one patch per email, and you need to include a changelog for each patch. Personally, I don't think the sentences in question need to be changed though.
[1] http://winehq.org/site/sending_patches
Personally, I don't think the sentences in question need to be changed though.
[1] http://winehq.org/site/sending_patches
-- James Hawkins
The sentence is grammatically incorrect using "is" with "by now" as the phrase "by now" implies past tense and is grammatically incorrect. I was testing an application and saw the phrase pop up, and knew it was incorrect. The sentence should be re-structured for present tense.
http://experts.about.com/q/General-Writing-Grammar-680/question-21.htm
On 10/1/06, EA Durbin ead1234@hotmail.com wrote:
Personally, I don't think the sentences in question need to be changed though.
[1] http://winehq.org/site/sending_patches
-- James Hawkins
The sentence is grammatically incorrect using "is" with "by now" as the phrase "by now" implies past tense and is grammatically incorrect. I was testing an application and saw the phrase pop up, and knew it was incorrect. The sentence should be re-structured for present tense.
http://experts.about.com/q/General-Writing-Grammar-680/question-21.htm
Thanks for the explanation, but I never said the grammar was correct. I spoke my personal opinion that such a change is not worth the effort, and that the sentence is fine and understandable as is. No need to get defensive about it :)
-
EA Durbin -
James Hawkins