Re: Compile fix forinclude files from linux 2.6.7

[Marcus Meissner]

On Sun, Sep 05, 2004 at 05:38:03PM +0200, Rein Klazes wrote:
> Hi,
>
> Fix for bugzilla bug#2354, compile failure on Slackware 10.
>
> The include <linux/fd.h> uses since Linux 2.6.7 a macro defined in
> <linux/compiler.h>. Compiler.h is new in linux 2.4.4, old but not very
> old, so I added an autoconf check for such systems.
>
> Need to run autoheader & autoconf after applying.

No, if it is missing __user, just

#define __user

at the beginning of the file.

Or try not to use linux kernel headers at all.

Ciao, Marcus

Compile fix forinclude files from linux 2.6.7

[Rein Klazes]

On Sun, 5 Sep 2004 17:50:03 +0200, you wrote:
> On Sun, Sep 05, 2004 at 05:38:03PM +0200, Rein Klazes wrote:
> > Hi,
> >
> > Fix for bugzilla bug#2354, compile failure on Slackware 10.
> >
> > The include <linux/fd.h> uses since Linux 2.6.7 a macro defined in
> > <linux/compiler.h>. Compiler.h is new in linux 2.4.4, old but not very
> > old, so I added an autoconf check for such systems.
> >
> > Need to run autoheader & autoconf after applying.
>
> No, if it is missing __user, just
>
> #define __user
>
> at the beginning of the file.

Why exactly is that better?

My reasoning was that apparently, fd.h is supposed to be included only
after compiler.h so lets just do that.
> Or try not to use linux kernel headers at all.

They are not a linux kernel headers, they are libc headers and could be
different (they are different on my Debian system) then the linux kernel
headers. I know that is often neglected.

Rein.