Hi Francois,
Just some suggestions to improve your patch. Feel free to use the suggestions (or not).
On Friday, 7 August 2015 11:56:27 +0200 (CEST), Francois Gouget wrote:
- /* for keyframes allow to consume all unused bytes */
- /* for keyframes allow consuming all the unused bytes */
What about "allow keyframes to consume all unused bytes"?
- /* must we check for framesize to gain requested
- datarate or could we trust codec? */
- /* must we check for frame size to gain requested
- data rate or could we trust the codec? */
"must we check for frame size to gain the requested data rate or can we trust the codec?"
This would allow framing items (iterator_frameditems),
and finding the nearest item (LVFI_NEARESTXY) a lot more efficiently.
"This would allow us to frame items (iterator_frameditems) and find the nearest item (LVFI_NEARESTXY) far more efficiently."
/* to make tests pass we follow Windows behaviour and allow to read these fields only
/* to make tests pass we follow Windows behaviour and allow reading these fields only
"...we follow Windows' behaviour..." (apostrophe)
- Since, we're also allow to load ELF (pure) libraries and Wine ELF libraries
- Since, we also allow loading ELF (pure) libraries and Wine ELF libraries
"Since we also allow..." (no comma)
- /* XP doesn't allow to create bitmaps larger than 128 Mb */
- /* XP doesn't allow creating bitmaps larger than 128 MB */
"XP doesn't allow the creation of bitmaps larger than 128 MB"
FIXME("Mode doesn't allow to wrap. However, we should allow to overwrite current string\n");
FIXME("Mode doesn't allow wrapping. However, we should allow overwriting the current string\n");
"... However, we should allow the current string to be overwritten\n"
/* win7 doesn't allow to create a thread during process shutdown,
/* win7 doesn't allow creating a thread during process shutdown but
"win7 doesn't allow threads to be created during process shutdown, but..."
/* win7 doesn't allow to create a thread during process shutdown,* earlier Windows versions allow it, and DLL_THREAD_DETACH is
/* win7 doesn't allow creating a thread during process shutdown but* earlier Windows versions allow it. In that case DLL_THREAD_DETACH is
Same here.
- Native localui does not allow to delete a COM / LPT - Port (ERROR_NOT_SUPPORTED)
- Native localui does not allow deleting a COM / LPT - Port (ERROR_NOT_SUPPORTED)
"...does not allow COM/LPT-Ports to be deleted..."
-
Hugh McMaster