Re: [PATCH 3/6] d3drm: Implement IDirect3DRM*_CreateTexture. (v5)

[Henri Verbeet]

On 11 May 2016 at 21:19, Aaryaman Vasishta  wrote:
> - if (FAILED(hr = IDirect3DRMTexture3_InitFromImage(*texture, image)))
> - {
> -
>    IDirect3DRMTexture3_Release(*texture);
> -
>    return D3DRMERR_BADVALUE;
> - }

You're not using the value of "hr", so the assignment is redundant.

[PATCH 3/6] d3drm: Implement IDirect3DRM*_CreateTexture. (v5)

[Aaryaman Vasishta]

Right, will fix this, and resend the patch series with the other fixes as
well.

Cheers,
Aaryaman

On Fri, May 13, 2016 at 3:55 PM, Henri Verbeet  wrote:
> On 11 May 2016 at 21:19, Aaryaman Vasishta 
> wrote:
> > - if (FAILED(hr = IDirect3DRMTexture3_InitFromImage(*texture, image)))
> > - {
> > -
> >    IDirect3DRMTexture3_Release(*texture);
> > -
> >    return D3DRMERR_BADVALUE;
> > - }
>
> You're not using the value of "hr", so the assignment is redundant.